Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4844: Refactor Validity Conditions #6583

Merged
merged 10 commits into from May 29, 2023

Conversation

adietrichs
Copy link
Member

@adietrichs adietrichs commented Feb 25, 2023

Add a separate execution-layer validation section with the block validity rule changes.

Detailed list of changes:

  • use data gas for all accounting (instead of number of blobs)
    • update calc_excess_data_gas()
    • update block validation accounting
  • add block validation section
    • move data gas logic to this section
    • modify sufficient balance check
    • add per-block data gas limit
    • require at least one blob per blob tx
    • check prefix byte

There is still an open question as to how to handle the relationship between data gas limit and CL max blobs per block limit, however this is considered out of scope for this PR.

@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Feb 25, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 25, 2023

✅ All reviewers have approved.

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor! we need to make sure the actual substantive changes here are highlighted. maybe list them very explicitly in the PR header comment.

I left a number of nits, some of which are not directly related to your changes

EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Show resolved Hide resolved
EIPS/eip-4844.md Outdated
the `TransactionNetworkPayload` version of the transaction also includes `blobs` and `kzgs` (commitments list).
The execution layer verifies the wrapper validity against the inner `TransactionPayload` after signature verification as:

- All hashes in `blob_versioned_hashes` must start with the byte `BLOB_COMMITMENT_VERSION_KZG`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest unifying the naming of BLOB_COMMITMENT_VERSION_KZG (in EIP) with VERSIONED_HASH_VERSION_KZG (in CL specs)

@Inphi
Copy link
Contributor

Inphi commented Apr 12, 2023

I think we can close this. Resolved via #6863

@adietrichs adietrichs changed the title Update EIP-4844: Refactor Validity Conditions & Ban Zero Blob Txs Update EIP-4844: Refactor Validity Conditions May 24, 2023
@adietrichs adietrichs requested a review from djrtwo May 24, 2023 18:13
ralexstokes
ralexstokes previously approved these changes May 24, 2023
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! I think we should definitely specify the blob limit this way

I left one comment that would help clarify although it could be obvious how the new checks interact with the old checks in which case we can disregard

EIPS/eip-4844.md Outdated Show resolved Hide resolved
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dash in EL and CL

EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
EIPS/eip-4844.md Outdated Show resolved Hide resolved
lightclient
lightclient previously approved these changes May 25, 2023
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after Alex's feedback is addressed

@adietrichs
Copy link
Member Author

updated the PR description to reflect all changes made.

@lightclient lightclient marked this pull request as ready for review May 29, 2023 15:08
@lightclient lightclient requested a review from eth-bot as a code owner May 29, 2023 15:08
@lightclient lightclient reopened this May 29, 2023
@eth-bot eth-bot enabled auto-merge (squash) May 29, 2023 15:16
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit ed61569 into ethereum:master May 29, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants