Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5570: Move to Last Call #6703

Closed
wants to merge 1 commit into from

Conversation

darcys22
Copy link
Contributor

No description provided.

@darcys22 darcys22 requested a review from eth-bot as a code owner March 17, 2023 21:58
@github-actions github-actions bot added c-status Changes a proposal's status t-erc labels Mar 17, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 17, 2023

File EIPS/eip-5570.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-review Waiting on editor to review label Mar 17, 2023
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't usually block an EIP for content-related reasons, but this has some pretty significant privacy concerns, namely, doxxing the Ethereum address used to submit a transaction, their IRL name, telephone number, email address, and physical address and revealing the contents of everything the person has bought.

The above should be addressed before this moves to last call.

@eth-bot eth-bot changed the title Move ERC-5570 to Last Call Update EIP-5570: Move to Last Call Mar 22, 2023
@darcys22
Copy link
Contributor Author

I wouldn't usually block an EIP for content-related reasons, but this has some pretty significant privacy concerns, namely, doxxing the Ethereum address used to submit a transaction, their IRL name, telephone number, email address, and physical address and revealing the contents of everything the person has bought.

The above should be addressed before this moves to last call.

Hi @Pandapip1 thanks for raising this. I have made a response in the ethereum cat herders thead because its such an important topic. https://ethereum-magicians.org/t/idea-standard-digital-receipts-using-erc-721/9908/40

Do you think this information should be conveyed directly in the ERC? I can update it to include a note recommending that the metadata be encrypted, but the description of how to encrypt it is out of scope for this ERC

@SamWilsn
Copy link
Contributor

SamWilsn commented Apr 18, 2023

Is this ready to go to last call, or are you still sorting out the privacy issues? If it isn't ready, would you mind making this a draft pull request?

@darcys22
Copy link
Contributor Author

Hi @SamWilsn i believe it is ready for last call (but definitely needing a privacy NFT ERC to be made in the future to work with this ERC).

i didnt get a response to my comment, i was thinking about adding a line to the ERC saying the privacy issues would be out of scope and recommending the data be encrypted. But that was just going to be a stab in the dark to try resolve pandapips concerns

@darcys22 darcys22 closed this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants