Add EIP: Automatic Transaction Representation #7023
Conversation
eth-bot
added
e-consensus
Shouldn't this go to draft first? |
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
github-actions
bot
added
s-draft
Pandapip1
changed the title
eth-bot
changed the title
ghost
mentioned this pull request
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
eth-bot
changed the title
|
The commit 6a4f26d (as a parent of 90764ac) contains errors. |
There was a problem hiding this comment.
I have two blocking concerns with this EIP.
First, it doesn't seem to have anything to do with ERC-712 as mentioned in the description.
Second, I'm not sure a set of UX guidelines is appropriate for an EIP. It's likely that these recommendations will change over time, leading to a bunch of Final proposals that aren't the latest best practices. I know you try to handle this by introducing versioning, but it still feels...inappropriate.
| - If a request comes from a non-URI source (e.g. a QR code), the wallet MUST indicate the source of the request to the user. | ||
| - If a request comes from a URI source, the wallet MUST indicate the source of the request to the user, including the URI scheme, host, and port. If the transaction originates from an unsafe (as determined by the wallet) embedded frame (e.g. an iframe or webview), the wallet MUST indicate this to the user and add a warning that the request may not be trustworthy. |
There was a problem hiding this comment.
These two bullet points feel a little weird. I might suggest:
| - If a request comes from a non-URI source (e.g. a QR code), the wallet MUST indicate the source of the request to the user. | |
| - If a request comes from a URI source, the wallet MUST indicate the source of the request to the user, including the URI scheme, host, and port. If the transaction originates from an unsafe (as determined by the wallet) embedded frame (e.g. an iframe or webview), the wallet MUST indicate this to the user and add a warning that the request may not be trustworthy. | |
| - Wallets MUST indicate the source of the request to the user. | |
| - If a request comes from a URI source, this indication MUST indicate the source of the request to the user, including the URI scheme, host, and port. If the transaction originates from an unsafe (as determined by the wallet) embedded frame (e.g. an iframe or webview), this indication MUST indicate this to the user and add a warning that the request may not be trustworthy. |
| - The verified source code of any referenced contracts with verified source code MUST be made available to the user. | ||
| - Users MUST be able to permanently dismiss verified source code warnings by address, chain ID, or address/chain ID pair, and a link to verify the source code of any contract MUST be provided. | ||
| - If the wallet can determine if a contract has been audited: | ||
| - For each contract referenced in a transaction: |
There was a problem hiding this comment.
This wording is a bit ambiguous. Does this mean in the to field of the transaction, or any contract called while executing? Does this also include contract deployments?
|
I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually. As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process. If there is relevant history here, please link to this PR from the new pull request. On behalf of the EIP Editors, I apologize for this inconvenience. |
No description provided.