Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7199: Move to Withdrawn #7225

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

SamWilsn
Copy link
Contributor

No description provided.

@SamWilsn SamWilsn requested a review from eth-bot as a code owner June 23, 2023 20:10
@github-actions github-actions bot added c-status Changes a proposal's status s-withdrawn This EIP is Withdrawn t-meta labels Jun 23, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 23, 2023

File EIPS/eip-7199.md

Requires 1 more reviewers from @xinbenlv

@eth-bot eth-bot changed the title Withdraw EIP-7199 Update EIP-7199: Move to Withdrawn Jun 23, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label Jun 23, 2023
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Should have been a modification to EIP-1.

@Joachim-Lebrun
Copy link
Contributor

Joachim-Lebrun commented Jun 24, 2023

+1. Should have been a modification to EIP-1.

indeed, and should have been opened as an issue instead of a new EIP. But still i believe the content is quite relevant, there has been so much changes in the auto review bot checks that i believe most of the existing EIPs would be failing the auto review if they were proposed now

Copy link

github-actions bot commented Nov 5, 2023

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Nov 5, 2023
@SamWilsn
Copy link
Contributor Author

Merging as per ethcatherders/EIPIP#289

@SamWilsn SamWilsn merged commit f7cd603 into ethereum:master Nov 15, 2023
15 of 16 checks passed
@SamWilsn SamWilsn deleted the withdraw-7199 branch November 15, 2023 15:53
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-status Changes a proposal's status s-withdrawn This EIP is Withdrawn t-meta w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants