Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-6900: Spec update 2 #7247

Merged
merged 13 commits into from Jul 3, 2023
Merged

Conversation

adam-alchemy
Copy link
Contributor

  • Removed the execution mode enum from IStandardExecutor. Now, it is only expected to use call.
    • Non-standard native account functions that use other call modes, such as delegatecall, are not prohibited by the spec.
  • Changed plugin init operation to an array of call operations instead of a delegatecall.
  • All plugin function signatures have been collected in one spec section for clarity.
  • Pre user op validation functions now return a packed time bound, which is intersected with the validator-returned value.
  • Specified behavior for natively-defined functions on the account.
  • Specified operation order for updatePlugins (pending plugin function updates do not apply until after execution completes - i.e. after all postExec hooks return and the call frame is complete).
  • Updated rationale section, fixed a typo, and updated the two call paths diagram.

adam-alchemy and others added 11 commits June 21, 2023 18:02
Co-authored-by: Jay Paik <jaypaik@users.noreply.github.com>
Co-authored-by: Jay Paik <jaypaik@users.noreply.github.com>
Co-authored-by: Jay Paik <jaypaik@users.noreply.github.com>
Co-authored-by: Jay Paik <jaypaik@users.noreply.github.com>
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-erc labels Jun 27, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 3, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update ERC-6900: Spec update 2 Update EIP-6900: Spec update 2 Jul 3, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label Jul 3, 2023
@eth-bot eth-bot enabled auto-merge (squash) July 3, 2023 18:46
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 3907772 into ethereum:master Jul 3, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants