New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Remove BLAKE2 compression precompile #7266
Conversation
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
✅ All reviewers have approved. |
blake2f
(0x09
) Precompileblake2f
(0x09
) Precompile
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
blake2f
(0x09
) PrecompileSigned-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
any opinions/comments @jochem-brouwer @holgerd77 @acolytec3 @gabrocheleau |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
F
precompile
The commit d904992 (as a parent of 59e8b38) contains errors. |
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
F
precompileSigned-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@lightclient @g11tech all recommendations have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for draft eip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
This EIP removes the
blake2f
(0x09
) precompile changing the precompile behaviour to result in an exceptional abort.