Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Remove BLAKE2 compression precompile #7266

Merged
merged 16 commits into from Jul 20, 2023
Merged

Add EIP: Remove BLAKE2 compression precompile #7266

merged 16 commits into from Jul 20, 2023

Conversation

pcaversaccio
Copy link
Contributor

@pcaversaccio pcaversaccio commented Jul 3, 2023

This EIP removes the blake2f (0x09) precompile changing the precompile behaviour to result in an exceptional abort.

Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Jul 3, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 3, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Add EIP: Remove blake2f (0x09) Precompile Add EIP: Remove blake2f (0x09) Precompile Jul 3, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jul 3, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 3, 2023
@pcaversaccio pcaversaccio changed the title Add EIP: Remove blake2f (0x09) Precompile Add EIP: Remove blake2f (0x09) Precompile Jul 3, 2023
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@eth-bot eth-bot changed the title Add EIP: Remove blake2f (0x09) Precompile Add EIP: Remove blake2f (0x09) Precompile Jul 3, 2023
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jul 3, 2023
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 4, 2023
EIPS/eip-remove_blake2f_precompile.md Outdated Show resolved Hide resolved
EIPS/eip-remove_blake2f_precompile.md Outdated Show resolved Hide resolved
EIPS/eip-remove_blake2f_precompile.md Outdated Show resolved Hide resolved
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@g11tech
Copy link
Contributor

g11tech commented Jul 19, 2023

any opinions/comments @jochem-brouwer @holgerd77 @acolytec3 @gabrocheleau

EIPS/eip-7266.md Outdated Show resolved Hide resolved
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

EIPS/eip-7266.md Outdated Show resolved Hide resolved
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
@eth-bot eth-bot changed the title Add EIP: Remove blake2f (0x09) Precompile Add EIP: Remove BLAKE2 compression function F precompile Jul 19, 2023
@github-actions
Copy link

The commit d904992 (as a parent of 59e8b38) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 19, 2023
EIPS/eip-7266.md Outdated Show resolved Hide resolved
EIPS/eip-7266.md Show resolved Hide resolved
EIPS/eip-7266.md Outdated Show resolved Hide resolved
EIPS/eip-7266.md Outdated Show resolved Hide resolved
EIPS/eip-7266.md Outdated Show resolved Hide resolved
EIPS/eip-7266.md Outdated Show resolved Hide resolved
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
@eth-bot eth-bot changed the title Add EIP: Remove BLAKE2 compression function F precompile Add EIP: Remove BLAKE2 compression precompile Jul 19, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 19, 2023
pcaversaccio and others added 6 commits July 20, 2023 00:06
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
Copy link
Contributor Author

@lightclient @g11tech all recommendations have been resolved.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for draft eip

@eth-bot eth-bot enabled auto-merge (squash) July 20, 2023 03:06
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 2583104 into ethereum:master Jul 20, 2023
15 of 16 checks passed
@pcaversaccio pcaversaccio deleted the blake2f branch July 20, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants