Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7212: Move to Review #7277

Merged
merged 3 commits into from Jul 11, 2023
Merged

Update EIP-7212: Move to Review #7277

merged 3 commits into from Jul 11, 2023

Conversation

ulerdogan
Copy link
Contributor

Move EIP-7212 to Review

EIP-7212: Precompiled for secp256r1 Curve Support

Any feedback and review is appreciated in the discussion in the FEM.

@ulerdogan ulerdogan requested a review from eth-bot as a code owner July 4, 2023 11:26
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-core labels Jul 4, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 4, 2023 •
edited

✅ All reviewers have approved.

@eth-bot eth-bot added the e-review Waiting on editor to review label Jul 4, 2023
@ulerdogan ulerdogan mentioned this pull request Jul 5, 2023
Closed
15 tasks
SamWilsn
SamWilsn reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things I can't comment directly on:

  • "The proposal aims creating precompiled contract..." should be "This proposal creates a precompiled contract...".
  • You'll need to define the value of PRECOMPILED_ADDRESS.

@eth-bot eth-bot enabled auto-merge (squash) July 11, 2023 15:11
eth-bot
eth-bot approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 0e6a9c9 into ethereum:master Jul 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ulerdogan @eth-bot @SamWilsn