Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Interactive across multiple registries #7336

Closed
wants to merge 1 commit into from

Conversation

zihaoccc
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 15, 2023

File EIPS/eip-7336.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jul 15, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 15, 2023
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Jul 15, 2023
@eth-bot eth-bot changed the title Add new EIP: UDoN to support cross registry interactive Add EIP: The Universal Domain Namespace(UDoN) enables data retrieval from multiple registries Jul 15, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Jul 15, 2023
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jul 15, 2023
@eth-bot eth-bot changed the title Add EIP: The Universal Domain Namespace(UDoN) enables data retrieval from multiple registries Add EIP: The Universal Domain Namespace(UDoN) for registry Jul 15, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 15, 2023
@eth-bot eth-bot changed the title Add EIP: The Universal Domain Namespace(UDoN) for registry Add EIP: Interactive across multiple registries Jul 15, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 15, 2023
Copy link

@ProphetZX ProphetZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exists already and therefore obsolete.

@zihaoccc
Copy link
Contributor Author

zihaoccc commented Jul 16, 2023

Exists already and therefore obsolete.

May I ask you a kindly reference, please? Thanks

@zihaoccc zihaoccc marked this pull request as ready for review July 16, 2023 05:04
@zihaoccc zihaoccc requested a review from eth-bot as a code owner July 16, 2023 05:04
@github-actions
Copy link

The commit 7dbf5a7 (as a parent of 426ada1) contains errors.
Please inspect the Run Summary for details.

@zihaoccc zihaoccc force-pushed the new_eip branch 2 times, most recently from f4bb42d to f366ecc Compare July 17, 2023 02:52
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 17, 2023
@zihaoccc
Copy link
Contributor Author

dear editors, may I ask a kindly review if possible, that will be much appreciated. @axic, @Pandapip1, @SamWilsn, @xinbenlv


## Abstract

The objective of this EIP is to propose the **Universal Domain Namespace(UDoN)**, which aims to facilitate onchain registry entries. Each entry in this structure adopts a mapping type, allowing for interactive capabilities across multiple registries like [ENS](./eip-137.md) and [NFT accounts](./eip-6551.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking to ERC-6551 creates an implicit relationship between this proposal and that one. That mean ERC-7336 won't be able to advance beyond the status of ERC-6551 (currently Review.) This isn't a problem if it's intended on your part, I just wanted to mention it.


## Abstract

The objective of this EIP is to propose the **Universal Domain Namespace(UDoN)**, which aims to facilitate onchain registry entries. Each entry in this structure adopts a mapping type, allowing for interactive capabilities across multiple registries like [ENS](./eip-137.md) and [NFT accounts](./eip-6551.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The objective of this EIP is to propose the **Universal Domain Namespace(UDoN)**, which aims to facilitate onchain registry entries. Each entry in this structure adopts a mapping type, allowing for interactive capabilities across multiple registries like [ENS](./eip-137.md) and [NFT accounts](./eip-6551.md).
The objective of this EIP is to propose the **Universal Domain Namespace(UDoN)**, which aims to facilitate onchain registry entries. Each entry in this structure adopts a mapping type, allowing for interactive capabilities across multiple registries like [ENS](./eip-137.md) and NFT accounts like [ERC-6551](./eip-6551.md).


The key words “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY”, and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.

**The Universal Domain Namespace(UDoN)** is a singular contract that enables the retrieval of data from multiple registries, each defined under different protocols within its own namespace. These registries employ distinct methods for resolving the key-value pairs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EIPs are generally used to standardize ideas that require interoperability between multiple vendors. If there is a single UDoN registry, it may be more suited to be developed as a service or library as opposed to an EIP.

That's not to say you cannot propose UDoN here, but I would like to see some text in your Motivation that explains why this needs an EIP over some documentation on, for example, a GitHub Pages site.

```

Smart contracts implementing the standard MUST implement all of the functions in the interface.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe the Specification section is detailed enough to allow an implementer to implement this proposal. There should be enough information here that someone reading this proposal can implement the standard without necessarily having to read the reference implementation.


## Rationale

The rationale behind this EIP is to augment the efficiency and interoperability within the Ethereum ecosystem. It provides a seamless way to interact with different registries, ultimately simplifying the process of reading and retrieving data. This proposed interface will encourage the development of more efficient, interoperable and standardized solutions, leading to a more robust and integrated Ethereum ecosystem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all reads like Motivation, and should be moved there. The Rationale section is supposed to justify technical decisions made within the EIP itself, while the Motivation justifies the EIP as a whole.


## Security Considerations

Needs discussion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you include an HTML-style comment, the linter will make sure you replace it before moving to Review:

Suggested change
Needs discussion.
Needs discussion. <!-- TODO -->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We weakly prefer SVG, if you can provide one. If not, that's fine too!

@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants