Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Tokenized Reserve #7427

Merged
merged 43 commits into from
Sep 5, 2023
Merged

Add EIP: Tokenized Reserve #7427

merged 43 commits into from
Sep 5, 2023

Conversation

jimstir
Copy link
Contributor

@jimstir jimstir commented Jul 29, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@jimstir jimstir requested a review from eth-bot as a code owner July 29, 2023 08:25
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-process labels Jul 29, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 29, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Create EIP Update Template: Create EIP Jul 29, 2023
@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jul 29, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 29, 2023
@jimstir jimstir marked this pull request as draft July 29, 2023 14:42
@jimstir jimstir marked this pull request as ready for review July 29, 2023 14:42
@lightclient
Copy link
Member

Please don't delete the eip template.

@jimstir
Copy link
Contributor Author

jimstir commented Jul 29, 2023

Please don't delete the eip template.

Should I create another pull request, I was not aware I deleted the template

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a new file in the EIPS directory

@Pandapip1
Copy link
Member

Should I create another pull request, I was not aware I deleted the template

Do not create a second pull request. Commit to your existing git branch.

@jimstir
Copy link
Contributor Author

jimstir commented Jul 30, 2023

eip-tokenized-reserve.md

Should I create another pull request, I was not aware I deleted the template

Do not create a second pull request. Commit to your existing git branch.

Added template

@jimstir jimstir requested a review from Pandapip1 July 30, 2023 01:56
@github-actions github-actions bot added the c-update Modifies an existing proposal label Jul 30, 2023
@github-actions github-actions bot removed c-update Modifies an existing proposal t-process labels Jul 30, 2023
@eth-bot eth-bot changed the title Update Template: Create EIP Add EIP: Tokenized Reserve Jul 30, 2023
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jul 30, 2023
@github-actions github-actions bot added the t-erc label Jul 30, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Aug 8, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Aug 8, 2023
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Aug 9, 2023
EIPS/eip-7425.md Outdated Show resolved Hide resolved
EIPS/eip-7425.md Outdated Show resolved Hide resolved
EIPS/eip-7425.md Outdated Show resolved Hide resolved
EIPS/eip-7425.md Outdated Show resolved Hide resolved
jimstir and others added 4 commits August 22, 2023 19:59
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

The commit b34b462 (as a parent of 74916cd) contains errors.
Please inspect the Run Summary for details.

@eth-bot eth-bot enabled auto-merge (squash) September 5, 2023 15:19
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@SamWilsn SamWilsn dismissed Pandapip1’s stale review September 5, 2023 15:20

new file was created

@eth-bot eth-bot merged commit 3d20647 into ethereum:master Sep 5, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants