-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-4788: Mention genesis block with no existing beacon block root case #7445
Update EIP-4788: Mention genesis block with no existing beacon block root case #7445
Conversation
✅ All reviewers have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
@@ -75,6 +75,8 @@ Validity of the parent beacon block root is guaranteed from the consensus layer, | |||
|
|||
When verifying a block, execution clients **MUST** ensure the root value in the block header matches the one provided by the consensus client. | |||
|
|||
For a genesis block with no existing parent beacon block root the 32 zero bytes are used as a root placeholder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a genesis block with no existing parent beacon block root the 32 zero bytes are used as a root placeholder. | |
For a genesis block with no existing parent beacon block root, the root consisting of 32 zero bytes should be used in the block header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, now the old version still made it into the merged spec, was this intended? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
This just came up in a discussion on how to populate the new beacon block root header field for the case where Cancun starts at genesis and there is no beacon block root present for the genesis block.