Update EIP-4788: Mention genesis block with no existing beacon block root case #7445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
jochem-brouwer
approved these changes
Aug 1, 2023
ralexstokes
reviewed
Aug 1, 2023
| @@ -75,6 +75,8 @@ Validity of the parent beacon block root is guaranteed from the consensus layer, | |||
|
|
|||
| When verifying a block, execution clients **MUST** ensure the root value in the block header matches the one provided by the consensus client. | |||
|
|
|||
| For a genesis block with no existing parent beacon block root the 32 zero bytes are used as a root placeholder. | |||
There was a problem hiding this comment.
Suggested change
| For a genesis block with no existing parent beacon block root the 32 zero bytes are used as a root placeholder. | |
| For a genesis block with no existing parent beacon block root, the root consisting of 32 zero bytes should be used in the block header. |
There was a problem hiding this comment.
Ah, now the old version still made it into the merged spec, was this intended? 🤔
eth-bot
approved these changes
Aug 1, 2023
somnathb1
added a commit
to ledgerwatch/erigon
that referenced
this pull request
Aug 2, 2023
AskAlexSharov
pushed a commit
to ledgerwatch/erigon
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just came up in a discussion on how to populate the new beacon block root header field for the case where Cancun starts at genesis and there is no beacon block root present for the genesis block.