Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7329: Move to Last Call #7517

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Aug 23, 2023

Last call for EIP-7329 re-review.

Last call for EIP-7329 re-review.
@shemnon shemnon requested a review from eth-bot as a code owner August 23, 2023 20:09
@github-actions github-actions bot added c-status Changes a proposal's status t-meta labels Aug 23, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 23, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Last Call Update EIP-7329: Move to Last Call Aug 23, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Aug 23, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on individual lines. The only change that's necessary is removing "I've written a script...". That's mostly an implementation detail, and not really relevant to future readers

@eth-bot eth-bot enabled auto-merge (squash) August 31, 2023 15:37
eth-bot
eth-bot previously approved these changes Aug 31, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled August 31, 2023 19:35

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) August 31, 2023 19:36
eth-bot
eth-bot previously approved these changes Aug 31, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled September 5, 2023 02:33

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) September 5, 2023 02:33
eth-bot
eth-bot previously approved these changes Sep 5, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit de69586 into ethereum:master Sep 5, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review t-meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants