Skip to content

Add EIP: Zero-Knowledge Wormholes - #7522

Merged
eth-bot merged 8 commits into
ethereum:masterfrom
keyvank:master
Sep 5, 2023
Merged

Add EIP: Zero-Knowledge Wormholes#7522
eth-bot merged 8 commits into
ethereum:masterfrom
keyvank:master

Conversation

@keyvank

@keyvank keyvank commented Aug 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@keyvank
keyvank requested a review from eth-bot as a code owner August 24, 2023 18:20
@github-actions github-actions Bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Aug 24, 2023
@eth-bot

eth-bot commented Aug 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Add EIP: Zero-Knowledge Wormholes - Privacy extension for Ethereum Add EIP: Zero-Knowledge Wormholes - Privacy Extension for Ethereum Aug 24, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Aug 24, 2023
@github-actions github-actions Bot added the w-ci Waiting on CI to pass label Aug 24, 2023
@eth-bot eth-bot changed the title Add EIP: Zero-Knowledge Wormholes - Privacy Extension for Ethereum Add EIP: Zero-Knowledge Wormholes Aug 24, 2023
@github-actions github-actions Bot removed the w-ci Waiting on CI to pass label Aug 24, 2023
@github-actions

github-actions Bot commented Aug 24, 2023

Copy link
Copy Markdown

The commit bec2c66 (as a parent of 9fc5ab2) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions Bot added the w-ci Waiting on CI to pass label Aug 24, 2023
abcoathup
abcoathup reviewed Aug 25, 2023
View reviewed changes
Comment thread EIPS/eip-7522.md Outdated
@github-actions github-actions Bot removed the w-ci Waiting on CI to pass label Aug 25, 2023
@github-actions github-actions Bot added s-review This EIP is in Review and removed s-draft This EIP is a Draft labels Aug 28, 2023
0xScratch
0xScratch approved these changes Aug 29, 2023
View reviewed changes
Comment thread EIPS/eip-7503.md Outdated
g11tech
g11tech reviewed Aug 29, 2023
View reviewed changes
Comment thread EIPS/eip-7503.md

## Rationale

Cryptocurrency mixers like TornadoCash can successfully obfuscate Ethereum transactions, but it's

@g11tech g11tech Aug 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TC to this EIP comparison looks apples to oranges as this EIP doesn't preserve assets/tokens , unless natively supported by the protocol (for eth) or by smart contracts (for tokens).

@keyvank keyvank Aug 29, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, but if we limit ourselves to ETH transfers, this EIP and TC are comparable imo.

g11tech
g11tech reviewed Aug 29, 2023
View reviewed changes
Comment thread EIPS/eip-7503.md Outdated
g11tech
g11tech reviewed Aug 29, 2023
View reviewed changes
Comment thread EIPS/eip-7503.md Outdated
g11tech
g11tech reviewed Aug 29, 2023
View reviewed changes
Comment thread EIPS/eip-7503.md Outdated
g11tech
g11tech reviewed Aug 29, 2023
View reviewed changes
Comment thread EIPS/eip-7503.md
The spendable/unspendable addresses are not distinguishable, so we can exploit this fact and define
an spendability rule for the money sent to addresses that can't be spent using regular elliptic-curve
signatures. Using the help of Zero-Knowledge proofs, we can hide the transaction trace and design
a new privacy protocol, which is what this EIP is proposing.

@g11tech g11tech Aug 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you stop double claims of the spend since original burn is not identifiable

@keyvank keyvank Aug 29, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using a nullifer value (Just like TC), the nullifier can simply be the hash of the secret value.

amalnathsathyan
amalnathsathyan reviewed Aug 29, 2023
View reviewed changes

@amalnathsathyan amalnathsathyan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this EIP standard require the implementation of some sort of event emitting mechanisms so that this kind of transaction to be marked and tracked properly when some tracements are required? Or some kind flags to categorize these 'wormhole' addresses?

@nowherenowherenowhere nowherenowherenowhere mentioned this pull request Aug 30, 2023
Closed
@keyvank

keyvank commented Aug 30, 2023

Copy link
Copy Markdown
Contributor Author

Does this EIP standard require the implementation of some sort of event emitting mechanisms so that this kind of transaction to be marked and tracked properly when some tracements are required? Or some kind flags to categorize these 'wormhole' addresses?

The whole point is, a transfer to a wormhole address is completely indistinguishable from a transfer to a normal EOA address! Such a flag is not needed. When minting, a proof is submitted, showing that one of the txs is sending to a wormhole address.

nowherenowherenowhere
nowherenowherenowhere reviewed Aug 31, 2023
View reviewed changes
Comment thread EIPS/eip-7503.md Outdated
g11tech
g11tech requested changes Sep 2, 2023
View reviewed changes

@g11tech g11tech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update status to draft

@github-actions github-actions Bot added s-draft This EIP is a Draft and removed s-review This EIP is in Review labels Sep 4, 2023
g11tech
g11tech approved these changes Sep 5, 2023
View reviewed changes

@g11tech g11tech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eth-bot
eth-bot enabled auto-merge (squash) September 5, 2023 09:41
@eth-bot
eth-bot merged commit d31cd3e into ethereum:master Sep 5, 2023
eth-bot
eth-bot approved these changes Sep 5, 2023
View reviewed changes

@eth-bot eth-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g11tech g11tech g11tech approved these changes
@eth-bot eth-bot eth-bot approved these changes
+5 more reviewers
@amalnathsathyan amalnathsathyan amalnathsathyan left review comments
@abcoathup abcoathup abcoathup left review comments
@nowherenowherenowhere nowherenowherenowhere nowherenowherenowhere left review comments
@0xScratch 0xScratch 0xScratch approved these changes
@Makeuptehrani Makeuptehrani Makeuptehrani approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@keyvank @eth-bot @amalnathsathyan @abcoathup @g11tech @0xScratch @Makeuptehrani @nowherenowherenowhere