Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-2539: Move to Draft #7535

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Update EIP-2539: Move to Draft #7535

merged 8 commits into from
Sep 19, 2023

Conversation

hujw77
Copy link
Contributor

@hujw77 hujw77 commented Aug 29, 2023 •
edited
Loading

For substrate light client, the zk-solution which use BLS12-377, requires the hash_to_curve function to verify the aggregated signatures.
So I add the field element to curve mapping operation like BLS12-381.

@hujw77 hujw77 requested a review from eth-bot as a code owner August 29, 2023 09:06
@github-actions github-actions bot added c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core labels Aug 29, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 29, 2023 •
edited
Loading

File EIPS/eip-2539.md

Requires 1 more reviewers from @shamatar

@hujw77 hujw77 changed the title Add field element to curve mapping operation EIP-2539: Add field element to curve mapping operation Aug 29, 2023
@eth-bot eth-bot changed the title EIP-2539: Add field element to curve mapping operation Update EIP-2539: Add field element to curve mapping operation Aug 29, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label Aug 29, 2023
@hujw77
Copy link
Contributor Author

hujw77 commented Aug 29, 2023

@shamatar Please take a review.

@github-actions github-actions bot added c-status Changes a proposal's status s-draft This EIP is a Draft labels Aug 29, 2023
@eth-bot eth-bot changed the title Update EIP-2539: Add field element to curve mapping operation Update EIP-2537: Move to Draft Aug 29, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Aug 29, 2023
@g11tech
Copy link
Contributor

g11tech commented Aug 29, 2023

could you decouple the PR to individual EIPS

@github-actions github-actions bot removed c-status Changes a proposal's status s-draft This EIP is a Draft labels Aug 30, 2023
@eth-bot eth-bot changed the title Update EIP-2537: Move to Draft Update EIP-2539: Move to Draft Aug 30, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Aug 30, 2023
@github-actions github-actions bot added c-status Changes a proposal's status s-draft This EIP is a Draft and removed c-update Modifies an existing proposal s-stagnant This EIP is Stagnant labels Aug 30, 2023
@hujw77
Copy link
Contributor Author

hujw77 commented Aug 30, 2023

could you decouple the PR to individual EIPS

Done.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Aug 30, 2023
@hujw77 hujw77 mentioned this pull request Aug 30, 2023
Merged
@hujw77 hujw77 mentioned this pull request Sep 5, 2023
Closed
21 tasks
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

The commit 27aa8af (as a parent of 46a0b78) contains errors.
Please inspect the Run Summary for details.

@hujw77 hujw77 mentioned this pull request Sep 5, 2023
Merged
SamWilsn
SamWilsn reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to fix the eipw errors on the Checks tab.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Sep 6, 2023
@hujw77
Copy link
Contributor Author

hujw77 commented Sep 6, 2023 •
edited
Loading

You'll also need to fix the eipw errors on the Checks tab.

Fixed. @SamWilsn

@hujw77 hujw77 requested a review from SamWilsn September 6, 2023 03:16
@hujw77 hujw77 mentioned this pull request Sep 11, 2023
Closed
21 tasks
@g11tech
Copy link
Contributor

g11tech commented Sep 13, 2023

@shamatar could you review and/or appove adding @hujw77 as co-author?

@shamatar
Copy link
Contributor

How can I do it?

@hujw77
Copy link
Contributor Author

hujw77 commented Sep 18, 2023 •
edited
Loading

How can I do it?

@shamatar, you could review this PR, and approve me as co-author.
Just answer @g11tech 's question.

@shamatar
Copy link
Contributor

I'm not in the reviewers set of this PR, otherwise changes look fine for me

g11tech
g11tech approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as @shamatar approves all changes

@SamWilsn SamWilsn merged commit a22ce0f into ethereum:master Sep 19, 2023
10 checks passed
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
@hujw77
Update EIP-2539: Move to Draft (ethereum#7535)
e41684a 
* Add field element to curve mapping operation

* Add author

* Move to Draft

* Update addresses table

* Fix CI error

* Fix CI error

* Fix CI error

* Fix CI error

Author approved in ethereum#7535 (comment)
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
@hujw77 @RaphaelHardFork
Update EIP-2539: Move to Draft (ethereum#7535)
6f5204e 
* Add field element to curve mapping operation

* Add author

* Move to Draft

* Update addresses table

* Fix CI error

* Fix CI error

* Fix CI error

* Fix CI error

Author approved in ethereum#7535 (comment)
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
@hujw77 @just-a-node
Update EIP-2539: Move to Draft (ethereum#7535)
fda5a78 
* Add field element to curve mapping operation

* Add author

* Move to Draft

* Update addresses table

* Fix CI error

* Fix CI error

* Fix CI error

* Fix CI error

Author approved in ethereum#7535 (comment)
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@hujw77 @GAEAlimited
Update EIP-2539: Move to Draft (ethereum#7535)
f02ef78 
* Add field element to curve mapping operation

* Add author

* Move to Draft

* Update addresses table

* Fix CI error

* Fix CI error

* Fix CI error

* Fix CI error

Author approved in ethereum#7535 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

@SamWilsn SamWilsn Awaiting requested review from SamWilsn

Assignees
No one assigned
Labels
a-review Waiting on author to review c-status Changes a proposal's status s-draft This EIP is a Draft t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hujw77 @eth-bot @g11tech @shamatar @SamWilsn