Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Multi-User NFT Extension #7634

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Add EIP: Multi-User NFT Extension #7634

merged 5 commits into from
Sep 21, 2023

Conversation

minkyn
Copy link
Contributor

@minkyn minkyn commented Sep 4, 2023

No description provided.

@minkyn minkyn requested a review from eth-bot as a code owner September 4, 2023 05:17
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Sep 4, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 4, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Add eip-nft_multi_user draft Add EIP: Multi-User NFT Extension Sep 4, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Sep 4, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Sep 4, 2023
abcoathup
abcoathup reviewed Sep 4, 2023
View reviewed changes
EIPS/eip-nft_multi_user.md Outdated
@@ -0,0 +1,69 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
---
eip: 7507

Assigning next sequential EIP/ERC number.
EIP/ERC numbering changed to sequential from 7500 and is no longer the PR number.

Please also update the filename.

@poojaranjan poojaranjan mentioned this pull request Sep 5, 2023
Closed
21 tasks
0xScratch
0xScratch reviewed Sep 9, 2023
View reviewed changes
Copy link
Contributor

@0xScratch 0xScratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Attempt

@aa-eyup
Copy link

aa-eyup commented Sep 10, 2023

You might find this project interesting - it tries to provide similar functionality. It Some major differences is that 1) ability to access a given NFT is done through ownership of a token representing that specific access type 2) existing NFTs can "plug-in", inheriting functionality is unnecessary 3) revenues generated from selling access to a given NFT can be distributed to multiple accounts based on ownership share of the NFT

@minkyn
Copy link
Contributor Author

minkyn commented Sep 13, 2023 •
edited
Loading

Please find my reply in the forum. Thanks!

@minkyn minkyn closed this Sep 13, 2023
@minkyn minkyn reopened this Sep 13, 2023
@github-actions
Copy link

The commit bcd676b (as a parent of c88dd1d) contains errors.
Please inspect the Run Summary for details.

@nowherenowherenowhere nowherenowherenowhere mentioned this pull request Sep 14, 2023
Closed
@poojaranjan poojaranjan mentioned this pull request Sep 19, 2023
Closed
21 tasks
xinbenlv
xinbenlv reviewed Sep 21, 2023
View reviewed changes
EIPS/eip-7507.md Outdated

## Test Cases

Test cases available available at: [ERC7507.test.ts](../assets/eip-7507/test/ERC7507.test.ts):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Test cases available available at: [ERC7507.test.ts](../assets/eip-7507/test/ERC7507.test.ts):
Test cases available available at: [`ERC7507.test.ts`](../assets/eip-7507/test/ERC7507.test.ts):

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Sep 21, 2023
xinbenlv
xinbenlv approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on AllERCDevs today, otherwise good to merge as Draft

@eth-bot eth-bot enabled auto-merge (squash) September 21, 2023 16:00
eth-bot
eth-bot approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 0c1ba81 into ethereum:master Sep 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@0xScratch 0xScratch 0xScratch left review comments

@xinbenlv xinbenlv xinbenlv approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@minkyn @eth-bot @aa-eyup @xinbenlv @abcoathup @0xScratch