Add EIP: Dynamic On-Chain Token Attributes Repository #7635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proposal introduces the ability to assign attributes to NFTs in a public non-gated repository smart contract that is accessible at the same address in all of the networks. The repository smart contract is designed to be a common-good repository, meaning that it can be used by any ERC-721 or ERC-1155 compatible token.
github-actions
bot
added
c-new
|
✅ All reviewers have approved. |
eth-bot
changed the title
eth-bot
added
e-consensus
steven2308
reviewed
Sep 4, 2023
Co-authored-by: Steven Pineda <steven2308@outlook.com>
|
The commit 8d31ce5 (as a parent of 30149de) contains errors. |
21 tasks
SamWilsn
reviewed
Sep 5, 2023
EIPS/eip-x.md
Outdated
| @@ -0,0 +1,1075 @@ | |||
| --- | |||
| eip: XYZ | |||
There was a problem hiding this comment.
Suggested change
| eip: XYZ | |
| eip: 7508 |
EIPS/eip-x.md
Outdated
| --- | ||
| eip: XYZ | ||
| title: Dynamic On-Chain Token Attributes Repository | ||
| description: React to any Non-Fungible Tokens using Unicode emojis. |
There was a problem hiding this comment.
Maybe forgot to update the description?
EIPS/eip-x.md
Outdated
| type: Standards Track | ||
| category: ERC | ||
| created: 2023-08-15 | ||
| requires: 165 |
There was a problem hiding this comment.
Suggested change
| requires: 165 | |
| requires: 165, 712 |
I'd probably mention 712 here.
EIPS/eip-x.md
Outdated
|
|
||
| ### Message format for presigned emotes | ||
|
|
||
| The message to be signed by the `setter` in order for the attribute setting to be submitted by someone else is formatted as follows: |
There was a problem hiding this comment.
I'd recommend mentioning where this pre-signed stuff comes from. I think it's ERC-712?
SamWilsn
approved these changes
Sep 5, 2023
eth-bot
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal introduces the ability to assign attributes to NFTs in a public non-gated repository smart contract that is accessible at the same address in all of the networks. The repository smart contract is designed to be a common-good repository, meaning that it can be used by any ERC-721 or ERC-1155 compatible token.