Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5114: Move to Last Call #7637

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

MicahZoltu
Copy link
Contributor

Set the last call deadline quite a bit in the future because I'm not in a big hurry and I want to leave lots of time for any last minute feedback, but I can move this forward if desired by the editors.

Set the last call deadline quite a bit in the future because I'm not in a big hurry and I want to leave lots of time for any last minute feedback, but I can move this forward if desired by the editors.
@github-actions github-actions bot added c-status Changes a proposal's status t-erc labels Sep 4, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 4, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Moves 5114 to Last Call Update EIP-5114: Move to Last Call Sep 4, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Sep 4, 2023
@Allyszz Allyszz mentioned this pull request Sep 5, 2023
@ethereum ethereum deleted a comment from Allyszz Sep 5, 2023
@SamWilsn
Copy link
Contributor

SamWilsn commented Sep 5, 2023

Your last-call-deadline was in the past, so I bumped it to two weeks from now.

@eth-bot eth-bot enabled auto-merge (squash) September 5, 2023 14:40
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 8d604d6 into ethereum:master Sep 5, 2023
11 checks passed
@MicahZoltu
Copy link
Contributor Author

Bleh, meant to be 2024-01-01. Any problem with me updating it to be later? I want plenty of time for Last Call unless there is a desire to keep it short.

@MicahZoltu MicahZoltu deleted the patch-8 branch September 5, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants