Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Entity Component System #7651

Closed
wants to merge 13 commits into from
Closed

Conversation

HelloRickey
Copy link

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Sep 5, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 5, 2023

File EIPS/eip-7509.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot changed the title add eip-7509 Add EIP: Entity Component System Sep 5, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Sep 5, 2023
@SamWilsn
Copy link
Contributor

SamWilsn commented Sep 6, 2023

In the future, please don't create a new pull request. Just push to the same one until it's approved. Thanks!

EIPS/eip-7509.md Outdated Show resolved Hide resolved
EIPS/eip-7509.md Outdated Show resolved Hide resolved
EIPS/eip-7509.md Outdated Show resolved Hide resolved
EIPS/eip-7509.md Outdated Show resolved Hide resolved
EIPS/eip-7509.md Show resolved Hide resolved
EIPS/eip-7509.md Outdated Show resolved Hide resolved
assets/eip-7509/README.md Show resolved Hide resolved
@HelloRickey
Copy link
Author

Hey @SamWilsn Please check again. Do I need to modify anything else? thank you.

@HelloRickey
Copy link
Author

Hey @axic @Pandapip1 @SamWilsn @xinbenlv
Can you tell me any feedback? Thanks.

@g11tech
Copy link
Contributor

g11tech commented Oct 3, 2023

this is fairly interesting, would give it an indepth look :)

@HelloRickey
Copy link
Author

this is fairly interesting, would give it an indepth look :)

Thanks @g11tech , I'm working on some tools for it, FYI
https://ecscan.vercel.app/

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good w.r.t. enshrining ECS interface 👍

@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 26, 2023
@SamWilsn
Copy link
Contributor

@HelloRickey Sorry it's taken so long to get a review on this! I was caught up with reviewing EIPs submitted before sometime in June before we split the repositories... Once this is re-opened on the new repository, I'll give it a look when I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants