Update EIP-6963: make icon requirement wording consistent #7790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-status
|
✅ All reviewers have approved. |
|
The way I interpret the MUST is that "it MUST be 96 x 96 or larger" and it SHOULD be a square. AKA 95x95 is not allowed I think what's written is a bit confusing as I think the intention here is to only allow the second case and exclude the 3rd because it's not a square. |
|
I think it would be preferable to have both requirements as |
|
I don't think we have consensus on this one yet. So will hold off on making any changes |
kdenhartog
approved these changes
Oct 4, 2023
eth-bot
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this inconsistency with
SHOULDandMUSTfor the icon aspect ratio and resolution. I believe this should beSHOULD