Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Contract Discovery and eTLD+1 Association #7815

Closed
wants to merge 29 commits into from

Conversation

TtheBC01
Copy link

@TtheBC01 TtheBC01 commented Oct 4, 2023

At Snickerdoodle Labs, we've had good success leveraging whats proposed in this draft EIP in our own protocol. We decided to write it up as a proposal and see if the Ethereum community would also find it useful.

This proposal describes a simple standard to leverage TXT records to discover smart contracts and verify their association with a known DNS domain. This is enabled by the relatively recent support for DNS over HTTPS (DoH) by most major DNS providers.

@TtheBC01 TtheBC01 requested a review from eth-bot as a code owner October 4, 2023 21:59
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Oct 4, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 4, 2023

File EIPS/eip-7529.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot changed the title Draft EIP: DNS over HTTPS for contract discovery and eTLD+1 association Add EIP: DNS over HTTPS for Contract Discovery and eTLD+1 Association Oct 4, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Oct 4, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 4, 2023
@eth-bot eth-bot changed the title Add EIP: DNS over HTTPS for Contract Discovery and eTLD+1 Association Add EIP: DNS for Contract Discovery and eTLD+1 Association Oct 4, 2023
@@ -0,0 +1,157 @@
---
eip: XXXX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: XXXX
eip: 7528

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, adding now

@xinbenlv
Copy link
Contributor

xinbenlv commented Oct 4, 2023

Hi @TtheBC01 thanks for your draft. ERC Editor here.
I hereby assigning this ERC as ERC-7528. Please update the filename EIPS/eip-draft-contract-ownership-via-DoH.md to be EIPS/eip-7528.md

@eth-bot eth-bot changed the title Add EIP: DNS for Contract Discovery and eTLD+1 Association Add EIP: Contract Discovery and eTLD+1 Association Oct 4, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Oct 4, 2023
EIPS/eip-7528.md Outdated
@@ -0,0 +1,157 @@
---
eip: 7528
Copy link
Contributor

@abcoathup abcoathup Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: 7528
eip: 7529

Assigning next sequential EIP/ERC number. 7528 already assigned to #7808.
EIP/ERC numbering changed to sequential from 7500 and is no longer the PR number.

Please also update the filename.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, on it

@github-actions
Copy link

The commit 98c034e (as a parent of a0568b2) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 25, 2023
@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 26, 2023
@TtheBC01
Copy link
Author

All good, we'll reopen it in the appropriate place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants