Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-6963: Move to Final #7816

Merged
merged 1 commit into from Oct 11, 2023
Merged

Update EIP-6963: Move to Final #7816

merged 1 commit into from Oct 11, 2023

Conversation

pedrouid
Copy link
Contributor

@pedrouid pedrouid commented Oct 5, 2023

Moving EIP-6963 from "Last Call" to "Final" status

To be merged on 10 Oct 2023

@pedrouid pedrouid requested a review from eth-bot as a code owner October 5, 2023 13:58
@github-actions github-actions bot added c-status Changes a proposal's status s-final This EIP is Final t-interface labels Oct 5, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 5, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title EIP-6963: Move to "Final" status Update EIP-6963: Move to Final Oct 5, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Oct 5, 2023
@darrylyeo
Copy link

I'd like to tighten up the terminology and suggest one last name change before this goes final:
#7824

Copy link
Contributor

@glitch-txs glitch-txs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@GregTheGreek GregTheGreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eth-bot eth-bot enabled auto-merge (squash) October 11, 2023 13:39
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit bb1ca48 into ethereum:master Oct 11, 2023
19 of 20 checks passed
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 6963 state from Last Call to Final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-final This EIP is Final t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants