Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7542: Update EIP-7542 to reflect its alignment with EIP-4444 #7906

Merged
merged 22 commits into from Oct 27, 2023
Merged

Update EIP-7542: Update EIP-7542 to reflect its alignment with EIP-4444 #7906

merged 22 commits into from Oct 27, 2023

Conversation

smartprogrammer93
Copy link
Contributor

@smartprogrammer93 smartprogrammer93 commented Oct 22, 2023 •
edited

Quoting 4444 from the user experience section:

In the first phase, clients don’t prune historical data by default. They introduce a command line option similar to geth’s --txlookuplimit that users can use if they want to prune historical data.

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-networking labels Oct 22, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 22, 2023 •
edited

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update EIP-7542 to clarify its alignment with 4444 Add EIP: eth/69 - available-blocks-extended protocol Oct 22, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Oct 22, 2023
@github-actions github-actions bot added c-update Modifies an existing proposal and removed c-new Creates a brand new proposal labels Oct 22, 2023
@eth-bot eth-bot changed the title Add EIP: eth/69 - available-blocks-extended protocol Update EIP-7542: eth/69 - available-blocks-extended protocol Oct 22, 2023
@smartprogrammer93 smartprogrammer93 marked this pull request as ready for review October 23, 2023 16:20
@smartprogrammer93 smartprogrammer93 changed the title Update EIP-7542: eth/69 - available-blocks-extended protocol Update EIP-7542 to reflect its alignment with EIP-4444 Oct 23, 2023
@domothyb
Copy link

should an explicit dependency on 4444 be listed on line 11?

@smartprogrammer93
Copy link
Contributor Author

smartprogrammer93 commented Oct 23, 2023 •
edited

@domothyb I don't believe it is. as this will need to be implemented in first phase of 4444 before it is fully implemented. Also, the network could benefit from this EIP for the syncing peers regardless if we prune history or not.
As such i don't see the dependency exist, but I can be wrong.

@lightclient lightclient reopened this Oct 27, 2023
@eth-bot eth-bot changed the title Update EIP-7542 to reflect its alignment with EIP-4444 Update EIP-7542: Update EIP-7542 to reflect its alignment with EIP-4444 Oct 27, 2023
@eth-bot eth-bot enabled auto-merge (squash) October 27, 2023 14:49
eth-bot
eth-bot approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@lightclient
Copy link
Member

@smartprogrammer93 fyi there is an issue when you undraft a PR the eth-bot doesn't review it. So sometime you need to open and close it.

@smartprogrammer93
Copy link
Contributor Author

Thank you @lightclient 🙏

@eth-bot eth-bot merged commit ac3b0b4 into ethereum:master Oct 27, 2023
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smartprogrammer93 @eth-bot @domothyb @lightclient