Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP 7549: Move committee index outside Attestation #7944

Merged
merged 9 commits into from Nov 4, 2023

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Nov 1, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-new Creates a brand new proposal s-review This EIP is in Review t-core labels Nov 1, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 1, 2023

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Nov 1, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 1, 2023
EIPS/eip-75XX.md Outdated
@@ -0,0 +1,60 @@
---
eip: 75XX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7549 cc: @abcoathup

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 1, 2023
@dapplion dapplion force-pushed the attestation-index branch 2 times, most recently from e8fa646 to 7aff167 Compare November 1, 2023 08:18
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Nov 1, 2023
EIPS/eip-7549.md Outdated

1. Removing the field
2. Preserving the field and setting it to be zero
3. Changing the field type to Optional (from EIP7495 StableContainer)

This comment was marked as resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the dash notation, a linker requested me to link the EIP. How can I do that? Using the full URL returned another linter error

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good apart from a minor change requested for EIP referencing

EIPS/eip-7549.md Outdated Show resolved Hide resolved
@dapplion
Copy link
Contributor Author

dapplion commented Nov 2, 2023

CI breaking due to un-releated EIPs. Seem related to the ERC / EIP split

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 4, 2023
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eth-bot eth-bot enabled auto-merge (squash) November 4, 2023 11:18
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit c29595c into ethereum:master Nov 4, 2023
10 checks passed
@dapplion dapplion changed the title Add EIP: Move committee index outside Attestation Add EIP 7549: Move committee index outside Attestation Nov 22, 2023
Copy link

The commit 958072a (as a parent of c29595c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-review This EIP is in Review t-core w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants