New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP 7549: Move committee index outside Attestation #7944
Conversation
✅ All reviewers have approved. |
EIPS/eip-75XX.md
Outdated
@@ -0,0 +1,60 @@ | |||
--- | |||
eip: 75XX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7549
cc: @abcoathup
e8fa646
to
7aff167
Compare
EIPS/eip-7549.md
Outdated
|
||
1. Removing the field | ||
2. Preserving the field and setting it to be zero | ||
3. Changing the field type to Optional (from EIP7495 StableContainer) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using the dash notation, a linker requested me to link the EIP. How can I do that? Using the full URL returned another linter error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good apart from a minor change requested for EIP referencing
CI breaking due to un-releated EIPs. Seem related to the ERC / EIP split |
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
b5c074e
to
958072a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
The commit 958072a (as a parent of c29595c) contains errors. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: