Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Block-level Warming #7968

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

forshtat
Copy link
Contributor

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

…#4)

* Add article on the "compression" of access lists by execution clients

* Make a compressed access list as a required p2p protocol change

* Introduce a 32 gas minimum base fee equivalent for including an entry in ACL (#6)

* Set minimum cost of ACL entry to 32 gas; apply also to the Priority Fee
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Nov 14, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 14, 2023

File EIPS/eip-7557.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @Pandapip1, @SamWilsn

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Nov 14, 2023
@eth-bot eth-bot changed the title New EIP: Block-level warming of addresses and slots with access lists Add EIP: Global Warming Nov 14, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 14, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 14, 2023
@eth-bot eth-bot changed the title Add EIP: Global Warming Add EIP: Block-level Warming Nov 14, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 14, 2023
EIPS/eip-7968.md Outdated Show resolved Hide resolved
forshtat and others added 2 commits November 16, 2023 13:17
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Nov 16, 2023
Copy link

The commit c644cae (as a parent of 14eb98a) contains errors.
Please inspect the Run Summary for details.

is more complex.\
We propose the following approach to a fair reimbursement of the paid `priorityFee`:

1. The validator gets paid the `priorityFee` for each cold access only once, but according to the highest `priorityFee`
Copy link
Contributor

@g11tech g11tech Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. The validator gets paid the `priorityFee` for each cold access only once, but according to the highest `priorityFee`
1. The builder gets paid the `priorityFee` for each cold access only once, but according to the highest `priorityFee`

and similar such corrections below

among the transactions containing the said cold access.
2. The rest of the Ether that was charged by the validator as a `priorityFee` is redistributed back to all the senders
of transactions containing the same cold access in proportion to their **marginal contribution** to the total reimbursement.
3. The `marginal contribution` of a transaction to the total reimbursement is defined as the difference between the sum total
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the contribution of the the most expensive transaction is the second largest priority fee * gas cost. although this is fine but cost could just be proportionately reimbursed keeping it simple

In order to minimize the cost of permanently storing access lists, we propose the following changes to
the `execution_payload` structure:

1. Add a new `block_access_list` field. \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block_access_list also could be a derived thing from the per tx access list

"accessors": [
{
"sender": "0x90F8bf6A479f320ead074411a4B0e7944Ea8c9C1",
"priorityFeePerGas": "1000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although priorityFeePerGas is important to derive the reimbursements but they are again a picked from the txs, also sender info is not really important at this level. the compressed per tx reference can again resolve this

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core w-ci Waiting on CI to pass w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants