Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4844: Rename gasPrice to baseFee #8095

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

MicahZoltu
Copy link
Contributor

Type 2 transactions already use the "base fee" nomenclature. This change makes 4844 transactions consistent with that naming scheme.

Type 2 transactions already use the "base fee" nomenclature.  This change makes 4844 transactions consistent with that naming scheme.
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Jan 8, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 8, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Jan 8, 2024
@eth-bot eth-bot changed the title 4844: Rename gasPrice to baseFee Update EIP-4844: Rename gasPrice to baseFee Jan 8, 2024
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not necessarily against, but the data cost isn't exactly a "base" of the fee because it is exactly what the user will pay. There is no priority component of the data gas price.

Curious if other authors have thoughts on this?

@MicahZoltu
Copy link
Contributor Author

For type 2 transactions, the "base fee" is the fee that is automatically determined and charged by the protocol and burnt. The same is true for this fee IIUC, which is why it feels like it should share naming convention. Just as with type 2 transactions, other fees are likely necessary to incentivize inclusion, but that feels out of scope to me for determining the name of this fee.

@roberto-bayardo
Copy link
Contributor

FWIW I've been using this terminology already in some of the OP-stack 4844 work as I find it more clear, e.g.: ethereum-optimism/docs#386

@lightclient
Copy link
Member

We're talking about a header name though (or I guess in this gas, a value computed from a header value), the tx name just follows the value in the header. In 1559, there are multiple fee components, thus "base fee" name. In 4844, only a single fee component, therefore "gasprice".

In both cases, the tx name is "max_xxxx_per_gas".

@MicahZoltu
Copy link
Contributor Author

In hindsight, I think EIP-1559 should have named it protocolFeePerGas, which better represents what is being paid I think (the protocol enforced fee for a transaction). Unfortunately, that ship has sailed, but if we conceptually think of baseFee as a synonym for protocolFee, then I believe the 4844 fee we are referring to is also a protocolFee and thus, also a baseFee.

@g11tech
Copy link
Contributor

g11tech commented Jan 8, 2024

i think constants defintely can be changed becuase they are base fee part of constants anyway
regarding the other changes, i think since the blob priority will not happen as its priority is already rolled into normal priority (and block proposers in the end don't care how tips are divided), i am fine with the name change to base or protocol

@roberto-bayardo
Copy link
Contributor

I guess the opcode is already using the BLOBBASEFEE terminology https://eips.ethereum.org/EIPS/eip-7516

@s1na
Copy link
Contributor

s1na commented Jan 11, 2024

I want to add that internally in Geth this is called blob base fee which I agree is the more accurate name. blobGasPrice can be confusing because of the legacy tx's gas price which goes to the miner. Or we call this "burntFee", so the intention becomes clear.

@MicahZoltu
Copy link
Contributor Author

I like blobBaseFee to be consistent with type 2 transaction and London block header nomenclature. In hindsight, I would have preferred protocolFee instead of baseFee, but it is too late to change type 2 transactions or block header for post-London blocks.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rename was accepted/not contested in Jan 18 ACD, so lgtm

@eth-bot eth-bot enabled auto-merge (squash) February 8, 2024 20:24
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit a67f8e1 into ethereum:master Feb 8, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants