Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Hardfork Meta - Pectra #8121

Merged
merged 21 commits into from
Feb 12, 2024
Merged

Add EIP: Hardfork Meta - Pectra #8121

merged 21 commits into from
Feb 12, 2024
+59 −0

Conversation

timbeiko
Copy link
Contributor

@timbeiko timbeiko commented Jan 18, 2024 •
edited
Loading

ready to merge 😄

@timbeiko
first draft
82021cd 
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 18, 2024 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jan 18, 2024
@timbeiko
Typo + EthMag link
afd82d4 
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
@github-actions github-actions bot added c-new Creates a brand new proposal s-review This EIP is in Review t-meta labels Jan 18, 2024
@eth-bot eth-bot changed the title Prague/Electra Hardfork Meta Add EIP: Hardfork Meta - Prague/Electra Jan 18, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 18, 2024
@timbeiko
Change status
a7c862b 
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
@github-actions github-actions bot added s-draft This EIP is a Draft and removed s-review This EIP is in Review labels Jan 18, 2024
abcoathup
abcoathup reviewed Jan 18, 2024
View reviewed changes
EIPS/eip-praguemeta.md Outdated
@@ -0,0 +1,58 @@
---
eip: XXXX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: XXXX
eip: 7600

Assigning next sequential EIP/ERC/RIP number.
Numbering changed to sequential from 7500 and is no longer the PR number.

Please also update the filename.

abcoathup
abcoathup reviewed Jan 18, 2024
View reviewed changes
EIPS/eip-praguemeta.md Outdated
@@ -0,0 +1,58 @@
---
eip: XXXX
title: Hardfork Meta - Prague/Electra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Hardfork Meta - Prague/Electra
title: Hardfork Meta - Pectra

@lightclient named Prague + Electra upgrade as Pectra on all core devs - execution 178
https://www.youtube.com/watch?v=6xgxmKfVjtA&t=1890s

@timbeiko
ACDC 129 updates
80548bf 
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jan 25, 2024
@timbeiko
typo
f744e56 
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
ryanschneider
ryanschneider reviewed Jan 25, 2024
View reviewed changes
EIPS/eip-7600.md Outdated Show resolved Hide resolved
@g11tech @ryanschneider
Update EIPS/eip-7600.md
d2bbca8 
Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com>
g11tech
g11tech previously approved these changes Jan 26, 2024
View reviewed changes
abcoathup
abcoathup reviewed Jan 26, 2024
View reviewed changes
EIPS/eip-7600.md Outdated Show resolved Hide resolved
@timbeiko @abcoathup
Update EIPS/eip-7600.md
db62e8a 
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@poojaranjan poojaranjan mentioned this pull request Jan 30, 2024
Closed
10 tasks
@poojaranjan poojaranjan mentioned this pull request Jan 31, 2024
Closed
9 tasks
@poojaranjan poojaranjan mentioned this pull request Feb 6, 2024
Closed
21 tasks
SamWilsn
SamWilsn reviewed Feb 6, 2024
View reviewed changes
EIPS/eip-7600.md Outdated Show resolved Hide resolved
EIPS/eip-7600.md Outdated Show resolved Hide resolved
EIPS/eip-7600.md Outdated Show resolved Hide resolved
EIPS/eip-7600.md

## Rationale

This Meta EIP provides a global view of all changes included in the Prague/Electra network upgrade, as well as links to full specification.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rationale section should justify decisions made within the EIP, not the EIP as a whole. Unless you actually want to explain why these particular EIPs are being included, I think you should just omit this section as it doesn't really make sense. Would require an override on the bots though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last two Meta EIPs had such rationales, but I'm happy with whatever. Feels simpler to not have to override the bot all the time, but also OK to delete this.

For reference:

timbeiko and others added 3 commits February 7, 2024 07:39
@timbeiko @SamWilsn
Update EIPS/eip-7600.md
9ffd729 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@timbeiko @SamWilsn
Update EIPS/eip-7600.md
d68d128 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@timbeiko
Add CL specs links.
6085cf3
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

The commit 6085cf3 (as a parent of 3a4b287) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 7, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 7, 2024
@timbeiko timbeiko changed the title Add EIP: Hardfork Meta - Prague/Electra Add EIP: Hardfork Meta - Pectra Feb 8, 2024
@timbeiko
Copy link
Contributor Author

timbeiko commented Feb 8, 2024

We agreed to name this fork Pectra on ACDC#127 😄

@eth-bot eth-bot enabled auto-merge (squash) February 12, 2024 15:36
eth-bot
eth-bot approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 92daa1d into ethereum:master Feb 12, 2024
10 checks passed
@poojaranjan poojaranjan mentioned this pull request Feb 27, 2024
Closed
9 tasks
@poojaranjan poojaranjan mentioned this pull request Mar 26, 2024
Closed
24 tasks
@poojaranjan poojaranjan mentioned this pull request Apr 9, 2024
Closed
24 tasks
@poojaranjan poojaranjan mentioned this pull request May 7, 2024
Closed
15 tasks
@poojaranjan poojaranjan mentioned this pull request May 21, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanschneider ryanschneider ryanschneider left review comments

@abcoathup abcoathup abcoathup left review comments

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot eth-bot approved these changes

@Elenore23 Elenore23 Elenore23 approved these changes

@ap501boii ap501boii ap501boii approved these changes

@g11tech g11tech g11tech left review comments

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@timbeiko @eth-bot @ryanschneider @abcoathup @SamWilsn @g11tech @Elenore23 @ap501boii