Update EIP-152: Fix reference test #8390
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solidity example with the reference test of https://datatracker.ietf.org/doc/html/rfc7693#appendix-A is at least confusing because it declares values of type `bytes8` using a literal of length of 4 bytes.
github-actions
bot
added
c-update
File
|
eth-bot
changed the title
|
The commit 8da81ce (as a parent of 026ea35) contains errors. |
16 tasks
lightclient
approved these changes
Apr 11, 2024
19 tasks
SamWilsn
approved these changes
Apr 24, 2024
6 tasks
xinbenlv
approved these changes
Jun 5, 2024
|
For this kind of fix, can we just lower the requirement to just 2 editor-s approval? or even one should be ok |
1 task
g11tech
approved these changes
Jun 11, 2024
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solidity example with the reference test of https://datatracker.ietf.org/doc/html/rfc7693#appendix-A is at least confusing because it declares values of type
bytes8using a literal of length of 4 bytes.