Update EIP-2537: Rename multiexponentiation to MSM #8393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
ralexstokes
reviewed
Apr 6, 2024
|
+1 from my side |
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
eth-bot
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: https://ethereum-magicians.org/t/eip-2537-bls12-precompile-discussion-thread/4187/63
The spec is inconsistent and uses both additive notation (G!ADD and G1MUL) and multiplicative notation (G!MULTIEXP) for the elliptic curve group law.
Blockchain, cryptography and ZK research has settled in using the additive notation.
And previous BN254 EIPs (EIP196) already uses the additive notation.