This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
[WIP] Set keepalive on Unix Socket #5458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
reviewed
Jan 30, 2019
| @@ -86,6 +86,15 @@ bool UnixDomainSocketServer::StartListening() | |||
| ::bind(m_socket, reinterpret_cast<sockaddr*>(&m_address), sizeof(sockaddr_un)); | |||
| fs::permissions(m_path, fs::owner_read | fs::owner_write); | |||
| listen(m_socket, 128); | |||
|
|
|||
| int keepalive = 1; | |||
| if (setsockopt(m_socket, SOL_SOCKET, SO_KEEPALIVE, &keepalive, sizeof(keepalive) < 0) | |||
There was a problem hiding this comment.
syntax error
Suggested change
| if (setsockopt(m_socket, SOL_SOCKET, SO_KEEPALIVE, &keepalive, sizeof(keepalive) < 0) | |
| if (setsockopt(m_socket, SOL_SOCKET, SO_KEEPALIVE, &keepalive, sizeof(keepalive)) < 0) |
chfast
reviewed
Jan 30, 2019
| @@ -141,7 +150,7 @@ size_t UnixDomainSocketServer::Write(int _connection, string const& _data) | |||
|
|
|||
| size_t UnixDomainSocketServer::Read(int _connection, void* _data, size_t _size) | |||
| { | |||
| ssize_t r = read(_connection, _data, _size); | |||
| ssize_t r = recv(_connection, _data, _size, MSG_NOSIGNAL); | |||
|
Hold on a sec, I have more fixes to this PR. |
|
I'm newbie in context of socket programming. Is this still a problem? Some time ago I tried to use the unix socket server from libjson-rpc-cpp #4565 but it didn't work at all. There is not a lot of changes there (https://github.com/cinemast/libjson-rpc-cpp/commits/master/src/jsonrpccpp/server/connectors/unixdomainsocketserver.cpp) but we can try again. Maybe they can setup it better than we are doing it currently. |
|
It is, but this PR isn't finished. Please don't merge. |
|
I will not have time to ever finish this PR and it is not an issue anymore in Solidity. The problem however persists if anyone wants to fix it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the connection closed issue from ethereum/solidity#3825