-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate purity checker to vyper LLL #69
Comments
This should be handled before #66 |
@ralexstokes might be picking this one up |
These are some test cases rewritten in vyper. # when submitted to purity checker, these should return True
success_cases = [
"""
@public
def foo(x:int128) -> int128:
return x * 2
""",
"""
@public
def phooey(h:bytes32, v:uint256, r:uint256, s:uint256) -> address:
return ecrecover(h, v, r, s)
"""
]
# when submitted to purity checker, these should return False
failed_cases = [
"""
horse: int128
@public
def foo() -> int128:
return self.horse
""",
"""
@public
def foo() -> int128:
return block.number
"""
]
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 110.0 DAI (110.0 USD @ $1.0/DAI) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. has committed to working on this project to be completed 5 months, 4 weeks from now. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 4 months, 1 week from now. Please review their questions below:
|
@ralexstokes Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@ralexstokes Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@gitcoinbot refer #143 |
@ralexstokes. 👋 thanks for the atMention, but you need to install @gitcoinbot on this repo for me to be able to respond. More details in the documentation. ✌️ |
@ralexstokes Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Leaving a note that we should make sure that external accounts are impure. Edit: this is handled and there are tests covering this functionality. |
Snoozed the Gitcoin Bot warnings, @ralexstokes. Thanks for the responses 😄 |
This is complete. How do we pay out @ralexstokes? |
@djrtwo Expect payout in the next day or two. Great work @ralexstokes! |
@ralexstokes Can you click 'Submit Work' on Gitcoin here? If you need a bit of mainnet ETH, let me know on Gitcoin Slack or try the Gitcoin Faucet and we'll get some your way 🙂 |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 300.0 DAI (300.0 USD @ $1.0/DAI) has been submitted by: @gdipri01 please take a look at the submitted work:
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @ralexstokes.
|
Issue
Purity checker is currently written in the deprecated Serpent. We need to make updates to it but should stop relying on Serpent compiler
Proposed implementation
Example Vyper LLL and compile techniques here https://github.com/ethereum/casper/blob/master/tests/utils/valcodes.py
The text was updated successfully, but these errors were encountered: