Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release needed] BLS tests: fast_aggregate_verify inconsistent format v1.0.0-rc0 #22

Closed
mratsim opened this issue Oct 26, 2020 · 2 comments
Closed

[Release needed] BLS tests: fast_aggregate_verify inconsistent format v1.0.0-rc0 #22

mratsim opened this issue Oct 26, 2020 · 2 comments

Comments

@mratsim
Copy link

mratsim commented Oct 26, 2020

There is one test in fast_aggregate_verify that has an inconsistent format with the rest (fast_aggregate_verify_infinity_pubkey)

It uses messages (plural) instead of message

image
@mratsim
Copy link
Author

mratsim commented Oct 26, 2020

Fixed by ethereum/consensus-specs#2099 but I guess we need a new release for those who uses the tarballs directly.

For now I'll edit manually in my downloaded files

@mratsim mratsim changed the title BLS tests: fast_aggregate_verify inconsistent format v1.0.0-rc0 [Release needed] BLS tests: fast_aggregate_verify inconsistent format v1.0.0-rc0 Oct 26, 2020
mratsim added a commit to status-im/nim-blscurve that referenced this issue Oct 26, 2020
@mratsim
Workaround ethereum/consensus-spec-tests#22, ethereum/consensus-specs…
3f3d73a 
…#2099
mratsim added a commit to status-im/nim-blscurve that referenced this issue Oct 26, 2020
@mratsim
BLS signature v4 (#91)
3878b9b 
* Update vectors to BLSv4 v1.0.0-rc0 [skip ci]

* Workaround ethereum/consensus-spec-tests#22, ethereum/consensus-specs#2099

* Rework BLSv4 API ethereum/consensus-specs#2080 and address #76 #77

* Upgade Milagro vectors

* Upgrade BLST backend with new API

* BLST forgot to return true for publicFromSecret
@prestonvanloon prestonvanloon mentioned this issue Oct 29, 2020
Merged
3 tasks
@hwwhww
Copy link
Contributor

hwwhww commented Dec 4, 2020

fixed in v1.0.0 tests.

@hwwhww hwwhww closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hwwhww @mratsim