Update BLST And Herumi #7632
Update BLST And Herumi #7632
Conversation
There was a problem hiding this comment.
need to update the comment as we don't use the random any more
// VerifyMultipleSignatures verifies a non-singular set of signatures and its respective pubkeys and messages.
// This method provides a safe way to verify multiple signatures at once. We pick a number randomly from 1 to max
// uint64 and then multiply the signature by it. We continue doing this for all signatures and its respective pubkeys.
// S* = S_1 * r_1 + S_2 * r_2 + ... + S_n * r_n
// P'{i,j} = P{i,j} * r_i
// e(S*, G) = \prod_{i=1}^n \prod_{j=1}^{m_i} e(P'{i,j}, M{i,j})
// Using this we can verify multiple signatures safely.
… into fixBuildFromSource
… into fixBuildFromSource
… into fixBuildFromSource
Codecov Report
@@ Coverage Diff @@
## master #7632 +/- ##
=======================================
Coverage 61.82% 61.82%
=======================================
Files 425 425
Lines 29903 29903
=======================================
Hits 18487 18487
Misses 8502 8502
Partials 2914 2914 |
| msg := test.Input.Message | ||
| if msg == "" { | ||
| msg = test.Input.Messages | ||
| } | ||
| msgBytes, err := hex.DecodeString(msg[2:]) |
There was a problem hiding this comment.
Please add a comment or TODO why we have to do this. It should be fixed soon with ethereum/consensus-spec-tests#22
| @@ -7,6 +7,7 @@ type FastAggregateVerifyTest struct { | |||
| Input struct { | |||
| Pubkeys []string `json:"pubkeys"` | |||
| Message string `json:"message"` | |||
| Messages string `json:"messages"` | |||
There was a problem hiding this comment.
Same comment here about a TODO or comment. This should be removed after ethereum/consensus-spec-tests#22 is resolved.
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
when compiling from source. This PR fixes that by updating all the relevant dependencies and cleaning up mcl builds.
Which issues(s) does this PR fix?
N.A
Other notes for review