Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit big-int requirement #542

Closed
djrtwo opened this issue Jan 31, 2019 · 2 comments
Closed

Remove implicit big-int requirement #542

djrtwo opened this issue Jan 31, 2019 · 2 comments
Labels
general:enhancement New feature or request

Comments

@djrtwo
Copy link
Contributor

djrtwo commented Jan 31, 2019

Issue

"ties broken by favoring lower shard_block_root values" requires big integer comparison. We intend to not have big integer requirement in the beacon chain.

@vbuterin
Copy link
Contributor

vbuterin commented Feb 1, 2019

That could be handled with string comparison.... although the fact that we now use little endian makes this ambiguous forcing us to explicitly state that we are using string comparison and not integer comparison (gah I hate little endian more 😆). Most programming languages support string comparison so I don't see this being a problem.

@hwwhww hwwhww added the general:enhancement New feature or request label Feb 3, 2019
@arnetheduck
Copy link
Contributor

string / lexicographical comparison of the byte sequence of the SSZ serialization of the hash seems like an easy and unambiguous way to do it?

fwiw, in statically typed languages we usually don't look at the hash as an integer at all - it's just a blob, so the bigint interpretation left things a bit open and would require going backwards through the serialization anyway, to actually implement it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants