Add seed domains #1415
Merged
Add seed domains #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Put `domain_type` and `epoch` upfront. This pattern can be reused for signature domains. 2) Change `int_to_bytes(epoch, length=32)` to `int_to_bytes(epoch, length=8)` to match `uint64` length.
Closed
JustinDrake
approved these changes
Sep 23, 2019
djrtwo
commented
Sep 23, 2019
|
@JustinDrake See review |
This was referenced Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reuses domain types for seeds (in addition to signatures) to isolate the source of randomness for different functions. The motivating factor was to cleanly prevent phase 1 persistent committees from colliding with phase 0 crosslink committees once per
PERSISTENT_COMMITTEE_PERIOD.ACTIVATION_EXIT_DELAYwas also changed toMAX_SEED_LOOKAHEADto be more generic and descriptive in its phase 1 usage. Also note thatMAX_SEED_LOOKAHEADwill increase with VDF-based randomness.