add lower bound slot condition on block gossip #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
requested changes
Feb 12, 2020
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
djrtwo
force-pushed
the
min-block-slot-gossip-val
branch
from
2373ae0
to
f441fad
Compare
mkalinin
reviewed
Feb 13, 2020
| @@ -251,6 +251,7 @@ There are two primary global topics used to propagate beacon blocks and aggregat | |||
|
|
|||
| - `beacon_block` - This topic is used solely for propagating new signed beacon blocks to all nodes on the networks. Signed blocks are sent in their entirety. The following validations MUST pass before forwarding the `signed_beacon_block` on the network | |||
| - The block is not from a future slot (with a `MAXIMUM_GOSSIP_CLOCK_DISPARITY` allowance) -- i.e. validate that `signed_beacon_block.message.slot <= current_slot` (a client MAY queue future blocks for processing at the appropriate slot). | |||
| - The block is from a slot greater than the latest finalized slot (with a `MAXIMUM_GOSSIP_CLOCK_DISPARITY` allowance) -- i.e. validate that `signed_beacon_block.message.slot > compute_start_slot_at_epoch(state.finalized_checkpoint.epoch)` (a client MAY choose to validate and store such blocks for additional purposes -- e.g. slashing detection, archive nodes, etc). | |||
There was a problem hiding this comment.
We should consider that depending on the configuration of the mesh a portion of such blocks may not reach slashing detectors and archive nodes at all.
There was a problem hiding this comment.
Yeah, I'm a bit mixed on how these DoS vectors should be handled wrt slashing detection.
Let's chat about it on next networking call
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lower bound in beacon block gossip condition in response to Least Authority audit.