remove IK handshake from p2p spec #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT: nevermind, got conf in the libp2p issue |
|
Yep. The So we currently just support XX, so fine with us to remove the others. |
raulk
approved these changes
Mar 18, 2020
9 tasks
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IK handshake is being removed from the libp2p noise specs for now (see here libp2p/specs#249), so removing it as optional in our specs.
I believe the XXFallback is to be removed as well. Waiting for conf here libp2p/specs#246 (comment)