Fix INACTIVITY_PENALTY_QUOTIENT
#1712
Merged
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1693 alternative
Issue
The amount of inactivity penalty was adjusted to half since we were applying penalty for missing FFG target and source. But now we only apply it for missing target, so
INACTIVITY_PENALTY_QUOTIENT
should have been2**24
.How did I solve it
Update
INACTIVITY_PENALTY_QUOTIENT
from2**25
to2**24
.Note that the status-quo
2**25
doesn't break security:#1693 (comment)
IMO this PR makes the current eth2.0-specs explainers (e.g., Serenity Design Rationale) stay consistent leaking rate. Also, we can avoid making
INACTIVITY_PENALTY_QUOTIENT
configuration explainer complicated in #1693.It's not required for testnet, but it would be nice to include this configuration adjustment in the final v1.0.0 ™️ spec.