Update to IETF BLS draft-irtf-cfrg-bls-signature-02 + draft-irtf-cfrg-hash-to-curve-07 #1799

hwwhww · 2020-05-09T03:54:13Z

As #1798 pointed out, adding a draft for v0.12.0.

May 12th Update: it's now following IETF BLS draft-irtf-cfrg-bls-signature-02 (including draft-irtf-cfrg-hash-to-curve-06)

If we want to include draft-irtf-cfrg-hash-to-curve-07 now, the spec would be changed to like:

Eth2 makes use of BLS signatures as specified in the IETF draft BLS specification v02 but uses Hashing to Elliptic Curves v07 instead of v06.

IMHO it's kinda strange and it would be nice to have a new BLS v03 release that includes H2C v7 soon.

May 13th update: it's now following IETF BLS draft-irtf-cfrg-bls-signature-02 +draft-irtf-cfrg-hash-to-curve-07.

hwwhww · 2020-05-12T18:40:42Z

/cc @prestonvanloon @mratsim @benjaminion @kirk-baird

djrtwo

couple minor comments

specs/phase0/beacon-chain.md

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>

mratsim

LGTM.

Small comment on the zero signature in phase 1.

Another thing is that ideally I'd like the verify functions to include the proof-of-possession verification or mention in the BLS paragraph that it assumed that PoP were verified at stage X.

mratsim · 2020-05-13T13:07:05Z

specs/phase1/shard-transition.md

+    if len(proposer_signatures) > 0:
+        proposer_signature_aggregate = bls.Aggregate(proposer_signatures)
+    else:
+        proposer_signature_aggregate = BLSSignature()


Do we define the empty signature somewhere? Is that 0xc000...

The python here would mean all zeroes (every ssz type is all zeroes by default). But agree that this is way to vague and can be confused with an empty signature.

I remember we had EMPTY_SIGNATURE constant in 2019. I would be happy to add it back.

We can have, NO_SIGNATURE(0x0000...) and EMPTY_SIGNATURE (0xc000...) for clarity

I've been treating EMPTY_SIGNATURE as (0x0000...) as I believe that's what we called in it the spec in 2019. I'm happy to do a re-name and make

NO_SIGNATURE (0x0000...) (always verifies false)

EMPTY_SIGNATURE (0xc000...)

However, we have to be careful here as AggregatePublicKeys([]) will always verify false according to the BLS Standard.

So EMPTY_SIGNATURE will only verify true against a list of EMPTY_PUBLIC_KEYS. We must have 1..* EMPTY_PUBLIC_KEYS verifying true. (Note: or some other combination of public keys that add to 0 mod r).

Or EMPTY_SIGNATURE(0x0000) and ZERO_SIGNATURE (0xc000) I'm not married to any name.

Hey I'm redirecting this discussion back to the original #1713 thread: #1713 (comment) 😄

prestonvanloon

Phase0 LGTM. Thanks!

hwwhww · 2020-05-14T09:49:01Z

@mratsim

Another thing is that ideally I'd like the verify functions to include the proof-of-possession verification or mention in the BLS paragraph that it assumed that PoP were verified at stage X.

We do state that the ciphersuite ID is BLS_SIG_BLS12381G2_XMD:SHA-256_SSWU_RO_POP_, it includes "POP".

Or do you mean PopProve(SK) and PopVerify(PK, proof) APIs? From my understanding, we don't use PopProve for the deposit proof-of-possession since we have to sign over withdrawal_credentials.

specs/phase0/beacon-chain.md

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>

1. Make sure that BLS -Verify APIs would only return `True` or `False` , no exceptions. 2. Use `eth2spec.utils.bls` instead of py_ecc for test generator 3. Add assertions in test generator 4. Add some special test cases for the -Verify APIs 5. Clean up the test format documents

Handle phase 1 `PKs == []` cases

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>

protolambda

Minor config thing. Looks good otherwise.

configs/mainnet.yaml

configs/minimal.yaml

Update BLS test suite to BLS standard draft v2 format

djrtwo

Just ran the test generators locally. All good

great job! and thank you everyone for all the input along the way :)

Update to IETF BLS draft-irtf-cfrg-bls-signature-02

cdd0ed0

hwwhww added the DO NOT MERGE label May 9, 2020

Bump py_ecc to v3.0.0 (IETF BLS v2 + H2C v6)

78d83b6

hwwhww force-pushed the bls_v2 branch from c5c63a5 to 78d83b6 Compare May 12, 2020 04:22

hwwhww marked this pull request as ready for review May 12, 2020 04:29

hwwhww added this to the v0.12.0 milestone May 12, 2020

hwwhww added 2 commits May 13, 2020 02:27

Bump py_ecc to v4.0.0 (IETF BLS v2 + H2C v7)

ed194de

Update IETF standard description

2718dcc

hwwhww changed the title ~~Update to IETF BLS draft-irtf-cfrg-bls-signature-02~~ Update to IETF BLS draft-irtf-cfrg-bls-signature-02 + draft-irtf-cfrg-hash-to-curve-07 May 12, 2020

hwwhww removed the DO NOT MERGE label May 12, 2020

hwwhww requested review from CarlBeek and protolambda May 12, 2020 18:35

hwwhww added the scope:BLS label May 12, 2020

djrtwo reviewed May 12, 2020

View reviewed changes

specs/phase0/beacon-chain.md Outdated Show resolved Hide resolved

specs/phase0/beacon-chain.md Outdated Show resolved Hide resolved

hwwhww and others added 2 commits May 13, 2020 12:56

Fix AggregateVerify param name: message -> messages

3c11a4d

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>

Apply feedback from Danny, add a note of the hash to curve configuration

4a246ba

mratsim approved these changes May 13, 2020

View reviewed changes

prestonvanloon approved these changes May 13, 2020

View reviewed changes

hwwhww mentioned this pull request May 14, 2020

Invalid empty attestation signatures consensus split #1713

Closed

hwwhww mentioned this pull request May 14, 2020

Handle phase 1 PKs == [] cases #1812

Merged

Use NO_SIGNATURE (0x00...) approach

aa436d9

djrtwo reviewed May 14, 2020

View reviewed changes

specs/phase0/beacon-chain.md Outdated Show resolved Hide resolved

hwwhww and others added 6 commits May 15, 2020 00:48

Remove leading space

6a3241b

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>

Apply PR feedback: add docstring

f0c4623

Merge pull request #1812 from ethereum/no_signature

689a695

Handle phase 1 `PKs == []` cases

Fix typo and remove unused variable

9a25598

Fix typo

ea99f0a

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>

hwwhww added 2 commits May 15, 2020 03:05

Fix typo

82073a4

Add a note of len(attestations) > 0

ab3cbda

protolambda approved these changes May 14, 2020

View reviewed changes

configs/mainnet.yaml Outdated Show resolved Hide resolved

configs/minimal.yaml Outdated Show resolved Hide resolved

hwwhww and others added 4 commits May 15, 2020 18:50

PR feedback from proto: revert configs

a9c4516

Add Aggregate() case

d07e594

Update README

fd3cce0

Merge pull request #1813 from ethereum/bls_v2_tests

4ffafa5

Update BLS test suite to BLS standard draft v2 format

djrtwo approved these changes May 15, 2020

View reviewed changes

djrtwo merged commit 4a86c39 into v012x May 18, 2020

djrtwo deleted the bls_v2 branch May 18, 2020 13:35

hwwhww mentioned this pull request May 18, 2020

BLS link points to expired draft #1798

Closed

ChihChengLiang mentioned this pull request May 20, 2020

Change api ChihChengLiang/milagro_bls_binding#14

Merged

terencechain mentioned this pull request May 20, 2020

Align to spec v0.12 prysmaticlabs/prysm#5935

Closed

25 tasks

paulhauner mentioned this pull request May 21, 2020

Tracking: spec v0.12.0 sigp/lighthouse#1182

Closed

22 tasks

benjaminion mentioned this pull request May 22, 2020

Is the BLS test aggregate_na_pubkeys correct? #1840

Closed

hwwhww mentioned this pull request May 23, 2020

Bump BLS library to align with Eth2 spec v0.12.0 version ethereum/staking-launchpad#78

Closed

ColinSchwarz mentioned this pull request May 25, 2020

Update BLS to use IETF bls draft 2 with hash-to-curve draft 7 ChainSafe/bls#11

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to IETF BLS draft-irtf-cfrg-bls-signature-02 + draft-irtf-cfrg-hash-to-curve-07 #1799

Update to IETF BLS draft-irtf-cfrg-bls-signature-02 + draft-irtf-cfrg-hash-to-curve-07 #1799

hwwhww commented May 9, 2020 •

edited

Loading

hwwhww commented May 12, 2020

djrtwo left a comment

mratsim left a comment •

edited

Loading

mratsim May 13, 2020

protolambda May 13, 2020

hwwhww May 13, 2020

mratsim May 13, 2020

kirk-baird May 13, 2020

mratsim May 14, 2020

hwwhww May 14, 2020

prestonvanloon left a comment

hwwhww commented May 14, 2020

protolambda left a comment

djrtwo left a comment

Update to IETF BLS draft-irtf-cfrg-bls-signature-02 + draft-irtf-cfrg-hash-to-curve-07 #1799

Update to IETF BLS draft-irtf-cfrg-bls-signature-02 + draft-irtf-cfrg-hash-to-curve-07 #1799

Conversation

hwwhww commented May 9, 2020 • edited Loading

hwwhww commented May 12, 2020

djrtwo left a comment

Choose a reason for hiding this comment

mratsim left a comment • edited Loading

Choose a reason for hiding this comment

mratsim May 13, 2020

Choose a reason for hiding this comment

protolambda May 13, 2020

Choose a reason for hiding this comment

hwwhww May 13, 2020

Choose a reason for hiding this comment

mratsim May 13, 2020

Choose a reason for hiding this comment

kirk-baird May 13, 2020

Choose a reason for hiding this comment

mratsim May 14, 2020

Choose a reason for hiding this comment

hwwhww May 14, 2020

Choose a reason for hiding this comment

prestonvanloon left a comment

Choose a reason for hiding this comment

hwwhww commented May 14, 2020

protolambda left a comment

Choose a reason for hiding this comment

djrtwo left a comment

Choose a reason for hiding this comment

hwwhww commented May 9, 2020 •

edited

Loading

mratsim left a comment •

edited

Loading