Ensure balances remain unchanged for optimal validators during leak #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this go into v0.12? |
|
Yes @q9f, we chatted with client teams yesterday before deciding on inclusion here. |
hwwhww
reviewed
May 20, 2020
tests/core/pyspec/eth2spec/test/phase_0/epoch_processing/test_process_rewards_and_penalties.py
Outdated
Show resolved
Hide resolved
|
All feedback addressed @hwwhww |
25 tasks
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1370 to preserve the design goal of "if attesting perfectly during an inactivity leak, your balance remains unchanged"
Approach: During an inactivity leak, do not scale base rewards by participation so that they perfectly cancel out with the baseline penalties applied for the inactivity leak (not including the actual quadratic leak portion).