Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure balance unchanged for optimal validators #5946

Merged
merged 3 commits into from
May 21, 2020
Merged

Ensure balance unchanged for optimal validators #5946

merged 3 commits into from
May 21, 2020

Conversation

terencechain
Copy link
Member

Part of #5935

Change list:

  • Align logic to ensure balances remain unchanged for optimal validators
  • Add New tests for new helper functions
  • Update existing test

Reference PR: ethereum/consensus-specs#1830

@terencechain terencechain requested a review from a team as a code owner May 21, 2020 17:45
@terencechain terencechain self-assigned this May 21, 2020
@terencechain terencechain requested review from shayzluf, 0xKiwi and prestonvanloon and removed request for a team May 21, 2020 17:45
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #5946 into v0.12 will decrease coverage by 0.01%.
The diff coverage is 65.38%.

@@            Coverage Diff             @@
##            v0.12    #5946      +/-   ##
==========================================
- Coverage   59.25%   59.23%   -0.02%     
==========================================
  Files         319      319              
  Lines       26869    26881      +12     
==========================================
+ Hits        15920    15922       +2     
- Misses       8774     8776       +2     
- Partials     2175     2183       +8     

@terencechain terencechain added Ready For Review A pull request ready for code review v0.12 labels May 21, 2020
Copy link
Contributor

@0xKiwi 0xKiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised no tests break for this change, LGTM though!

@terencechain
Copy link
Member Author

Surprised no tests break for this change, LGTM though!

One broke! The SlashedPenalty.. one
https://github.com/prysmaticlabs/prysm/pull/5946/files#diff-286fe299dc194625486fe6d619f1266aR282

@terencechain terencechain merged commit a56666c into v0.12 May 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the 1830 branch May 21, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants