Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tunable genesis #1866

Merged
merged 4 commits into from
Jun 2, 2020
Merged

Tunable genesis #1866

merged 4 commits into from
Jun 2, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jun 2, 2020

Supersedes #1861 with final CI patches

--------- Original Text ---------------

fixes #1849 (by implementing option 2)

  • renames MIN_GENESIS_DELAY to GENESIS_DELAY as this is a fixed constant now
  • bumps GENESIS_DELAY to 172800 (2 days)
  • simplifies genesis_time to be just eth1_timestamp + GENESIS_DELAY

Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I always liked, and part of the reason why the slot time is 12, and not 10 or 16, is that it aligns nicely with minutes, hours etc. With an arbitrary genesis time, and option 2, that breaks down to only aligning, but not being offset nicely.

So I've a slight preference for rounding (up) genesis time to the nearest hour. Or maybe the nearest minute.

Otherwise I agree with this change, it doesn't have to be offset exactly at midnight UTC.

Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment to the exact hour mark, or whatever offset we want to have for slot<>time conversion, is nice, but not critical. Once the genesis time is known, converting is really easy. We'll see if we miss the old behavior of perfect alignment to minutes/hours/days. For now though, this is all we need, so I am going to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tunable genesis time
3 participants