Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove prepare_payload #2683

Merged
merged 3 commits into from
Oct 19, 2021
Merged

remove prepare_payload #2683

merged 3 commits into from
Oct 19, 2021

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Oct 19, 2021

Remove prepare_payload in favor of a unification with notifiy_forkchoice_updated to map the methods as they are in the engine API.

See here -- ethereum/execution-apis#83 -- for associated removal in the engine API.


### `ExecutionEngine`
### `get_pow_block_at_terminal_total_difficulty`
Copy link
Contributor Author

@djrtwo djrtwo Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved get_pow_block_at_terminal_total_difficulty and get_terminal_pow_block up to helpers section.

No changes made to contents of the functions.

@djrtwo djrtwo requested a review from mkalinin October 19, 2021 00:14
Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! A few fixes related to prepare_payload function removal

specs/merge/validator.md Outdated Show resolved Hide resolved
specs/merge/validator.md Outdated Show resolved Hide resolved
specs/merge/validator.md Outdated Show resolved Hide resolved
specs/merge/validator.md Outdated Show resolved Hide resolved
@hwwhww hwwhww added the Bellatrix CL+EL Merge label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bellatrix CL+EL Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants