Implement Kintsugi specs 🍵 (the Merge November sprint PR)

[g11tech]

Motivation

PR is to implement Kintsugi 🍵 (the Merge November sprint)
Description

Consensus specs PR to implement. #3410

• Add terminal block hash override Add terminal block hash override ethereum/consensus-specs#2617
• Modify Merge Gossip Block Validation Conditions Modify Merge Gossip Block Validation Conditions ethereum/consensus-specs#2621~~ (Already Changed)
• add TBH_ACTIVATION_EPOCH add TBH_ACTIVATION_EPOCH ethereum/consensus-specs#2682
• remove prepare_payload remove prepare_payload ethereum/consensus-specs#2683
• Remove Union from ExecutionPayload transaction type Remove Union from ExecutionPayload transaction type ethereum/consensus-specs#2684
• fix gossip and tx size limits for the merge fix gossip and tx size limits for the merge ethereum/consensus-specs#2686
• remove extraneous p2p condition remove extraneous p2p condition ethereum/consensus-specs#2687
• remove gas validations from CL remove gas validations from CL ethereum/consensus-specs#2699-
• Add payload id as a return value to notify_forkchoice_updated Add payload id as a return value to notify_forkchoice_updated ethereum/consensus-specs#2711
• update penalty params for Merge update penalty params for Merge ethereum/consensus-specs#2698
• https://github.com/ethereum/consensus-specs/releases/tag/v1.1.5

Test Milestones

• Spec tests 1.1.4 1.1.5
• geth interop
• test transactions: https://notes.ethereum.org/_UH57VUPRrC-re3ubtmo2w

Moved Below to seperate task list #3425

• Optimistic Sync Implement optimistic sync CL <> EL #3433
• transaction testing integration in merge script
• https://github.com/ethereum/consensus-specs/blob/dev/specs/merge/p2p-interface.md#configuration
• EIP 4339 transaction test??

• --terminal-block-hash-override?

• --terminal-block-hash-epoch-override?

Closes #issue_number
#3410
Steps to test or reproduce

[codeclimate]

Code Climate has analyzed commit c15bf07 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	4

View more on Code Climate.

[codecov]

Codecov Report

Merging #3418 (c15bf07) into master (08dbb21) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3418      +/-   ##
==========================================
- Coverage   38.21%   38.19%   -0.02%     
==========================================
  Files         303      302       -1     
  Lines        7890     7894       +4     
  Branches     1207     1216       +9     
==========================================
  Hits         3015     3015              
- Misses       4734     4738       +4     
  Partials      141      141              

[dapplion]

Excellent! 🔥 Thanks for the push of timely delivering this

[dapplion]

@g11tech New specs version released already 💯 https://github.com/ethereum/consensus-specs/releases/tag/v1.1.5 please take a look. You can either do the changes on top of this PR or let's merge this one first and do the new 1.1.5 changes in a follow up PR.

[g11tech]

@g11tech New specs version released already 100 https://github.com/ethereum/consensus-specs/releases/tag/v1.1.5 please take a look. You can either do the changes on top of this PR or let's merge this one first and do the new 1.1.5 changes in a follow up PR.

@dapplion
this is done and committed into this PR as tasks were minor 👍 (have moved two issues GOSSIP/CHUNK size and processOperations dedup into new tracker #3425 for easier management)
also the geth merge interop is done for m1, a a small part of m2 as well (runGethPostMerge)

[dapplion]

To keep this PR simple can you please drop all the recent commits regarding optimistic sync and add them in a new PR?

[dapplion]

Looks great! Thank you so much for leading this push 🔥 excellent!

For upcoming PR on fast moving targets like this please keep PRs focus and atomic to prevent reviewers from having to review the same work +10 times. For example in this case building a new branch that fork from this PR head and creating the new PR once this is merge after a rebase.

[g11tech]

Looks great! Thank you so much for leading this push fire excellent!

For upcoming PR on fast moving targets like this please keep PRs focus and atomic to prevent reviewers from having to review the same work +10 times. For example in this case building a new branch that fork from this PR head and creating the new PR once this is merge after a rebase.

👍 and Thank you! 🙂