Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP4844: Clarify ratelimit behavior for sidecar with zero blobs #3174

Merged
merged 7 commits into from
Jan 12, 2023
Merged

EIP4844: Clarify ratelimit behavior for sidecar with zero blobs #3174

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5a75704
Clarify behavior for empty blobs sidecar
terencechain Dec 23, 2022
42121ad
Clarify what empty means
terencechain Dec 23, 2022
518c49b
Update specs/eip4844/p2p-interface.md
terencechain Dec 23, 2022
491bb1d
Clean ups
terencechain Dec 23, 2022
7204b5c
Merge branch 'clarify-empty-blob-sidecar' of github.com:terencechain/…
terencechain Dec 23, 2022
96a5536
Add rate limit suggestion
terencechain Jan 10, 2023
8d841c8
minor copy edit
djrtwo Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions specs/eip4844/p2p-interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,8 @@ The request MUST be encoded as an SSZ-container.
The response MUST consist of zero or more `response_chunk`.
Each _successful_ `response_chunk` MUST contain a single `BlobsSidecar` payload.

In cases where a slot contains a `BlobSidecar` that does not contain any blobs, but contain non-zero `beacon_block_root` and `beacon_block_slot`, `blobs_sidecar` **may be** skipped.
Copy link
Contributor

@g11tech g11tech Dec 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In cases where a slot contains a `BlobSidecar` that does not contain any blobs, but contain non-zero `beacon_block_root` and `beacon_block_slot`, `blobs_sidecar` **may be** skipped.
In cases where a slot contains a `BlobSidecar` that does not contain any blobs, but contain non-zero `beacon_block_root`, `beacon_block_slot` and a valid `kzg_aggregated_proof`, `blobs_sidecar` **may be** skipped.


Clients MUST keep a record of signed blobs sidecars seen on the epoch range
`[max(current_epoch - MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS, EIP4844_FORK_EPOCH), current_epoch]`
where `current_epoch` is defined by the current wall-clock time,
Expand All @@ -247,6 +249,8 @@ disconnect and/or temporarily ban such an un-synced or semi-synced client.
Clients MUST respond with at least the first blobs sidecar that exists in the range, if they have it,
and no more than `MAX_REQUEST_BLOBS_SIDECARS` sidecars.

Clients MUST not respond with empty blobs sidecars.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify what an "empty" blob sidecar is. It's a BlobSidecar that does not contain any blobs, but it may contain a non-zero beacon_block_root and beacon_block_slot per get_blobs_sidecar.

Copy link
Contributor

@g11tech g11tech Dec 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Clients MUST not respond with empty blobs sidecars.
Clients MAY skip empty blobs sidecars.


The following blobs sidecars, where they exist, MUST be sent in consecutive order.

Clients MAY limit the number of blobs sidecars in the response.
Expand Down