Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in eip4844/BeaconBlocksByRoot docs #3188

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix typo in eip4844/BeaconBlocksByRoot docs #3188

merged 1 commit into from
Jan 5, 2023

Conversation

henridf
Copy link
Contributor

@henridf henridf commented Jan 4, 2023

No description provided.

@henridf
Copy link
Contributor Author

henridf commented Jan 4, 2023 •
edited
Loading

A related question that I'd be happy to address in this PR if the answer is straightforward: If BeaconBlocksByRoot is called with a post-EIP4844_FORK_EPOCH root(s), what should the RPC return ?

nvm this is a different concern, will address separately.

@hwwhww hwwhww added the general:proofread spelling, grammar, accuracy label Jan 5, 2023
@hwwhww hwwhww merged commit 19cf15b into ethereum:dev Jan 5, 2023
@henridf henridf deleted the patch-2 branch January 6, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
general:proofread spelling, grammar, accuracy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henridf @djrtwo @hwwhww