Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation Rule #3339

Open
wants to merge 171 commits into
base: dev
Choose a base branch
from
Open

Confirmation Rule #3339

wants to merge 171 commits into from

Commits on Apr 12, 2023

  1. Change to filter_block_tree required for the confirmation rule

    @saltiniroberto
    saltiniroberto committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    d137dbe View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. First draft implementation of the confirmation rule

    @saltiniroberto
    saltiniroberto committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e04c678 View commit details
    Browse the repository at this point in the history

  2. Rename safe-head.md

    @saltiniroberto
    saltiniroberto committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0a2e654 View commit details
    Browse the repository at this point in the history

  3. Require to run isConfirmed only on blocks from the current epoch

    @saltiniroberto
    saltiniroberto committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    d51ae0c View commit details
    Browse the repository at this point in the history

  4. Move get_leaf_block_roots to unused function section

    @saltiniroberto
    saltiniroberto committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    3c145ec View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. Compute remaining voting weight starting from current_slot + 1 rather… 

    … than block.slot + 1
    @saltiniroberto
    saltiniroberto committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    124eaba View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. Fix typo

    @saltiniroberto
    saltiniroberto committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    1b3eb7c View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Make mypy happy

    @saltiniroberto
    saltiniroberto committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    da75a4e View commit details
    Browse the repository at this point in the history

  2. Fix formula in isOneConfirmed

    @saltiniroberto
    saltiniroberto committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    e622582 View commit details
    Browse the repository at this point in the history

  3. Change ffg weight calculation and fix error in other fomula

    @saltiniroberto
    saltiniroberto committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    7cd6f41 View commit details
    Browse the repository at this point in the history

  4. Account for proposer boost

    @saltiniroberto
    saltiniroberto committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    4be510e View commit details
    Browse the repository at this point in the history

  5. Fix minor issue

    @saltiniroberto
    saltiniroberto committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    be8bfce View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Fix will_block_checkpoint_be_justified_by_end_of_the_current_epoch + … 

    …use conversion to int to avoid overflows
    @saltiniroberto
    saltiniroberto committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    e4ad646 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ethereum:dev' into confirmation_rule

    @saltiniroberto
    saltiniroberto committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    9bd335c View commit details
    Browse the repository at this point in the history

  3. minor updates

    @saltiniroberto
    saltiniroberto committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    f454b99 View commit details
    Browse the repository at this point in the history

  4. Increase style check line length for ease of development

    @saltiniroberto
    saltiniroberto committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    6f56d90 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Use latest_message for computing get_ffg_weight_supporting_checkpoint… 

    …_for_block
    @saltiniroberto
    saltiniroberto committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    dc95b43 View commit details
    Browse the repository at this point in the history

  2. Add helper function for calculating score

    @saltiniroberto
    saltiniroberto committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    89a2818 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Add functions to calculate score

    @saltiniroberto
    saltiniroberto committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a68c853 View commit details
    Browse the repository at this point in the history

  2. Use underscore for all function names

    @saltiniroberto
    saltiniroberto committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    c29053b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Removed files committed by mistake

    @saltiniroberto
    saltiniroberto committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    a6c91b4 View commit details
    Browse the repository at this point in the history

  2. Remove other files committed by mistake

    @saltiniroberto
    saltiniroberto committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    a69530d View commit details
    Browse the repository at this point in the history

  3. Moved functions for calculating the confirmation score to a separate 

    section
    @saltiniroberto
    saltiniroberto committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    5f8e88e View commit details
    Browse the repository at this point in the history

  4. Added very brief explainer

    @saltiniroberto
    saltiniroberto committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    3b6afe5 View commit details
    Browse the repository at this point in the history

  5. Add back get_safe_execution_payload_hash

    @saltiniroberto
    saltiniroberto committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    ad97ef9 View commit details
    Browse the repository at this point in the history

  6. Revert ffg support commputation to use attestations in leaf blocks

    @saltiniroberto
    saltiniroberto committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    bcc1c3f View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Doc

    @saltiniroberto
    saltiniroberto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    4d7b715 View commit details
    Browse the repository at this point in the history

  2. Make mypy happy

    @saltiniroberto
    saltiniroberto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c67cf35 View commit details
    Browse the repository at this point in the history

  3. doctoc

    @saltiniroberto
    saltiniroberto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c3a0f7f View commit details
    Browse the repository at this point in the history

  4. doc

    @saltiniroberto
    saltiniroberto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    2493cb3 View commit details
    Browse the repository at this point in the history

  5. Add doc and fix bug in get_max_adversary_percentage_to_ensure_block_c… 

    …heckpoint_is_justified_by_the_end_of_the_current_epoch
    @saltiniroberto
    saltiniroberto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    d338119 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/dev' into confirmation_rule

    @saltiniroberto
    saltiniroberto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    55bdbe0 View commit details
    Browse the repository at this point in the history

  7. Removed unused files

    @saltiniroberto
    saltiniroberto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    08e3abd View commit details
    Browse the repository at this point in the history

  8. Remove unrequired files

    @saltiniroberto
    saltiniroberto committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    3e29857 View commit details
    Browse the repository at this point in the history

  9. first pass for review

    @adiasg
    adiasg committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    3066ad4 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Merge pull request #2 from saltiniroberto/confirmation_rule_adiasg 

    First pass review
    @saltiniroberto
    saltiniroberto committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d53a44a View commit details
    Browse the repository at this point in the history

  2. Small fix to the doc

    @saltiniroberto
    saltiniroberto committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    9354dc7 View commit details
    Browse the repository at this point in the history

  3. Calculate vote_weight_till_now as diff between total and future

    @saltiniroberto
    saltiniroberto committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    1dff966 View commit details
    Browse the repository at this point in the history

  4. Fix link in bellatrix fork choice

    @saltiniroberto
    saltiniroberto committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    bd85b41 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. review pass 2

    @adiasg
    adiasg committed May 4, 2023
    Configuration menu
    Copy the full SHA
    16b26c1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from saltiniroberto/confirmation_rule_adiasg 

    General updates to confirmation rule
    @saltiniroberto
    saltiniroberto committed May 4, 2023
    Configuration menu
    Copy the full SHA
    9ccf48b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/dev' into confirmation_rule

    @saltiniroberto
    saltiniroberto committed May 4, 2023
    Configuration menu
    Copy the full SHA
    b8ac374 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. update confirmation score calc

    @adiasg
    adiasg committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b99e31f View commit details
    Browse the repository at this point in the history

  2. remove current_slot parameter

    @adiasg
    adiasg committed May 15, 2023
    Configuration menu
    Copy the full SHA
    0117eed View commit details
    Browse the repository at this point in the history

  3. use simplified comm weight calc for safe block

    @adiasg
    adiasg committed May 15, 2023
    Configuration menu
    Copy the full SHA
    446baeb View commit details
    Browse the repository at this point in the history

  4. add function for computing proposer score

    @adiasg
    adiasg committed May 15, 2023
    Configuration menu
    Copy the full SHA
    673b4f4 View commit details
    Browse the repository at this point in the history

  5. remove old code

    @adiasg
    adiasg committed May 15, 2023
    Configuration menu
    Copy the full SHA
    38ace65 View commit details
    Browse the repository at this point in the history

  6. use get_checkpoint_block

    @adiasg
    adiasg committed May 15, 2023
    Configuration menu
    Copy the full SHA
    ca5006d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. readability refactor

    @adiasg
    adiasg committed May 16, 2023
    Configuration menu
    Copy the full SHA
    9475b62 View commit details
    Browse the repository at this point in the history

  2. use float calculations

    @adiasg
    adiasg committed May 16, 2023
    Configuration menu
    Copy the full SHA
    668c97d View commit details
    Browse the repository at this point in the history

  3. Fix get_proposer_score

    @saltiniroberto
    saltiniroberto committed May 16, 2023
    Configuration menu
    Copy the full SHA
    6ccc528 View commit details
    Browse the repository at this point in the history

  4. Fix lint error

    @saltiniroberto
    saltiniroberto committed May 16, 2023
    Configuration menu
    Copy the full SHA
    97dc8be View commit details
    Browse the repository at this point in the history

  5. Merge pull request #5 from saltiniroberto/confirmation_rule_adiasg_ro… 

    …berto

Fix linting errors
    @adiasg
    adiasg committed May 16, 2023
    Configuration menu
    Copy the full SHA
    0b2751d View commit details
    Browse the repository at this point in the history

  6. fix lint errors

    @adiasg
    adiasg committed May 16, 2023
    Configuration menu
    Copy the full SHA
    49a1365 View commit details
    Browse the repository at this point in the history

  7. update toc

    @adiasg
    adiasg committed May 16, 2023
    Configuration menu
    Copy the full SHA
    6a75d4e View commit details
    Browse the repository at this point in the history

  8. function renaming

    @adiasg
    adiasg committed May 16, 2023
    Configuration menu
    Copy the full SHA
    03b194e View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. wip - update conf score comments

    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    b843dad View commit details
    Browse the repository at this point in the history

  2. fix multiplier

    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    185338c View commit details
    Browse the repository at this point in the history

  3. remove comments

    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    5c38f67 View commit details
    Browse the repository at this point in the history

  4. simplify confirmation score functions

    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    ba7cb1f View commit details
    Browse the repository at this point in the history

  5. attach paper

    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    c0efc70 View commit details
    Browse the repository at this point in the history

  6. Fix calculation bug in remaining_slots_in_current_epoch

    @saltiniroberto
    saltiniroberto committed May 17, 2023
    Configuration menu
    Copy the full SHA
    0041a00 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #6 from saltiniroberto/confirmation_rule_adiasg_ro… 

    …berto

Fix calculation issue in remaining_slots_in_current_epoch
    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    d8cbfbc View commit details
    Browse the repository at this point in the history

  8. minor update

    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    569366b View commit details
    Browse the repository at this point in the history

  9. Merge pull request #4 from saltiniroberto/confirmation_rule_adiasg 

    Large refactor
    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    dca4c34 View commit details
    Browse the repository at this point in the history

  10. change typing

    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    d792899 View commit details
    Browse the repository at this point in the history

  11. Update introductory notes

    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    0d9e1a1 View commit details
    Browse the repository at this point in the history

  12. rename conflicting function

    @adiasg
    adiasg committed May 17, 2023
    Configuration menu
    Copy the full SHA
    ee3991f View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. typo correction

    @adiasg
    adiasg committed May 18, 2023
    Configuration menu
    Copy the full SHA
    8b3ab9c View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. apply review from @hwwhww and @mkalinin

    @adiasg
    adiasg committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    79ffac1 View commit details
    Browse the repository at this point in the history

  2. function name case suggestion by @mkalinin

    @adiasg
    adiasg committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    448ffac View commit details
    Browse the repository at this point in the history

  3. some more suggestions from @mkalinin

    @adiasg
    adiasg committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    c79df70 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Roberto Saltini <38655434+saltiniroberto@users.noreply.github.com>
    @adiasg @saltiniroberto
    adiasg and saltiniroberto committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    91643d9 View commit details
    Browse the repository at this point in the history

  2. commit change

    @saltiniroberto
    saltiniroberto committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    17d528a View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Fix small bug

    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    50e94fa View commit details
    Browse the repository at this point in the history

  2. Port FFG support calculation to Altair logic

    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    988b875 View commit details
    Browse the repository at this point in the history

  3. Limit confirmation score negative values to -1

    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b8c2ba6 View commit details
    Browse the repository at this point in the history

  4. Fix ethereum#3339 (comment)

    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    bb4a6aa View commit details
    Browse the repository at this point in the history

  5. Fix doc 

    Co-authored-by: Etan Kissling <etan@status.im>
    @saltiniroberto @etan-status
    saltiniroberto and etan-status committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    783762a View commit details
    Browse the repository at this point in the history

  6. Fix doc

    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    956a0b7 View commit details
    Browse the repository at this point in the history

  7. Fix blank lines

    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    28e3f64 View commit details
    Browse the repository at this point in the history

  8. Fix types in get_committee_weight_between_slots

    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    bfe43ce View commit details
    Browse the repository at this point in the history

  9. Move from floats to ints

    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    ddf8772 View commit details
    Browse the repository at this point in the history

  10. Update doc to reflect usage of unbound int rather than floats

    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    ce5670a View commit details
    Browse the repository at this point in the history

  11. Moved missed float computations to int and fixed linting

    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    dd22c68 View commit details
    Browse the repository at this point in the history

  12. Replace float with integer arithmetic for calculations in get_committ… 

    …ee_weight_between_slots
    @saltiniroberto
    saltiniroberto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    9933161 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Fix https://github.com/ethereum/consensus-specs/pull/3339/files#r1230… 

    …361554
    @saltiniroberto
    saltiniroberto committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    1269ea5 View commit details
    Browse the repository at this point in the history

  2. Fix bug in fetching checkpoint state in get_ffg_confirmation_score an… 

    …d is_ffg_confirmed
    @saltiniroberto
    saltiniroberto committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    b9919b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Make flake8 happy

    @saltiniroberto
    saltiniroberto committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    0530af7 View commit details
    Browse the repository at this point in the history

  2. Use pulled up checkpoint state in get_ffg_support

    @saltiniroberto
    saltiniroberto committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    24b66c8 View commit details
    Browse the repository at this point in the history

  3. Fix bug in get_committee_weight_between_slots

    @saltiniroberto
    saltiniroberto committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    616ae4c View commit details
    Browse the repository at this point in the history

  4. Revert "Fix bug in get_committee_weight_between_slots" 

    This reverts commit 616ae4c.
    @saltiniroberto
    saltiniroberto committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    ae0bf67 View commit details
    Browse the repository at this point in the history

  5. Fix bug in get_committee_weight_between_slots

    @saltiniroberto
    saltiniroberto committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    9bcefc1 View commit details
    Browse the repository at this point in the history

  6. Fix bug in get_ffg_support

    @saltiniroberto
    saltiniroberto committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    444a7e6 View commit details
    Browse the repository at this point in the history

  7. Fix bug in get_confirmation_score

    @saltiniroberto
    saltiniroberto committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    b0b93f8 View commit details
    Browse the repository at this point in the history

  8. Fix div by 0 in get_ffg_confirmation_score

    @saltiniroberto
    saltiniroberto committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    a3c463f View commit details
    Browse the repository at this point in the history

  9. Add slashing_th par to get_confirmation_score and improve pre div-by-… 

    …0 fix
    @saltiniroberto
    saltiniroberto committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    d80b701 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Allow is_confirmed for blocks from the previous epoch

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3ea5598 View commit details
    Browse the repository at this point in the history

  2. Extend handling of previous epoch to get_score

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3ce6a0e View commit details
    Browse the repository at this point in the history

  3. Use block state for balances and refactor get_remaining_weight

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    8737f14 View commit details
    Browse the repository at this point in the history

  4. Fix return type issue in get_committee_weight_between_slots

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    72fb786 View commit details
    Browse the repository at this point in the history

  5. Refactor get_ffg_confirmation_score to reduce code repetition

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0e2e77a View commit details
    Browse the repository at this point in the history

  6. Refactor is_ffg_confirmed to reduce code duplication

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    1fb41c4 View commit details
    Browse the repository at this point in the history

  7. doctoc

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    9a45487 View commit details
    Browse the repository at this point in the history

  8. Add tests

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0d93f11 View commit details
    Browse the repository at this point in the history

  9. Refactor tests

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3e4837a View commit details
    Browse the repository at this point in the history

  10. Add get_confirmation_score checks in tests

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    2aba14f View commit details
    Browse the repository at this point in the history

  11. Make linter happy

    @saltiniroberto
    saltiniroberto committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a77a8b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Apply some of djrtwo’s review suggestions 

    Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
    @saltiniroberto @djrtwo
    saltiniroberto and djrtwo committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    12de731 View commit details
    Browse the repository at this point in the history

  2. Improve calculation for edge case in get_committee_weight_between_slots

    @saltiniroberto
    saltiniroberto committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    2760c72 View commit details
    Browse the repository at this point in the history

  3. Improve get_committee_weight_between_slots (more precise calculations… 

    … and readability)
    @saltiniroberto
    saltiniroberto committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    4433813 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Remove leftovers from previous code refactoring

    @saltiniroberto
    saltiniroberto committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    78bcb38 View commit details
    Browse the repository at this point in the history

  2. Aligned long function defs to the convention used in the rest of the … 

    …specs
    @saltiniroberto
    saltiniroberto committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    c32b9ef View commit details
    Browse the repository at this point in the history

  3. Simplify check on block epoch

    @saltiniroberto
    saltiniroberto committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    7333dde View commit details
    Browse the repository at this point in the history

  4. Remove duplicate line.

    @saltiniroberto
    saltiniroberto committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bb7fe9a View commit details
    Browse the repository at this point in the history

  5. Fix doc for is_ffg_confirmed & helpers

    @saltiniroberto
    saltiniroberto committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b69dfb6 View commit details
    Browse the repository at this point in the history

  6. Rename vars in is_confirmed

    @saltiniroberto
    saltiniroberto committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    20c101f View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Combine code for previous and current epoch in is_ffg_confirmed and g… 

    …et_ffg_confirmation_score + improve doc for get_ffg_confirmation_score
    @saltiniroberto
    saltiniroberto committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    b1d631a View commit details
    Browse the repository at this point in the history

  2. Use inline comments style rather than docstrings for comments related… 

    … to specific parts of a method
    @saltiniroberto
    saltiniroberto committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ad268ec View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Fix bug in get_committee_weight_between_slots 

    Co-authored-by: fradamt <104826920+fradamt@users.noreply.github.com>
    @saltiniroberto @fradamt
    saltiniroberto and fradamt committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    e29d0ac View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Move config par to Configuration, add constant definition and improve… 

    … description in config table
    @saltiniroberto
    saltiniroberto committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    e955658 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Implement early exit criteria for is_lmd_confirmed

    @saltiniroberto
    saltiniroberto committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    913260b View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. Add link to committee weight estimation, introduce adjustment factor … 

    …and fix possible rounding issue
    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    5e05100 View commit details
    Browse the repository at this point in the history

  2. Use compute_slots_since_epoch_start in get_committee_weight_between_s… 

    …lots
    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    ae1ef29 View commit details
    Browse the repository at this point in the history

  3. Fix variable names in get_committee_weight_between_slots

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    24b6db2 View commit details
    Browse the repository at this point in the history

  4. Use ceiling division everywhere in get_committee_weight_between_slots

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    1340706 View commit details
    Browse the repository at this point in the history

  5. Replace pythonic starred expression in get_leaf_block_roots with for … 

    …loop
    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    49a2a30 View commit details
    Browse the repository at this point in the history

  6. Rename var in get_ffg_support

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    c41b95d View commit details
    Browse the repository at this point in the history

  7. Allow for blocks from the previous epoch in find_confirmed_block, re-… 

    …add get_safe_beacon_block_root and restore get_safe_execution_payload_hash to use get_safe_beacon_block_root
    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    6961150 View commit details
    Browse the repository at this point in the history

  8. Fix the level of indentation of some of the headings

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    f29df8b View commit details
    Browse the repository at this point in the history

  9. Add test for get_safe_beacon_block_root

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    d243ce8 View commit details
    Browse the repository at this point in the history

  10. Temporary fork choice spec test change

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    c59f1fe View commit details
    Browse the repository at this point in the history

  11. Fix typo

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    f4a7a4f View commit details
    Browse the repository at this point in the history

  12. Add new line to make the linter happy

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    39d8b4f View commit details
    Browse the repository at this point in the history

  13. Add new line to make linter happy

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    33b555d View commit details
    Browse the repository at this point in the history

  14. Run confirmation rule tests only from bellatrix onwards

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    cfa521d View commit details
    Browse the repository at this point in the history

  15. Merge branch 'upstream/dev' into confirmation_rule

    @saltiniroberto
    saltiniroberto committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    7dfdcd7 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Fix possible rounding issue in get_committee_weight_between_slots

    @saltiniroberto
    saltiniroberto committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0b8eb0b View commit details
    Browse the repository at this point in the history

  2. Improve doc on using unbounded integers 

    Co-authored-by: Aditya Asgaonkar <adiasg@users.noreply.github.com>
    @saltiniroberto @adiasg
    saltiniroberto and adiasg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    499e4f6 View commit details
    Browse the repository at this point in the history

  3. Restore safe-block.md for now

    @saltiniroberto
    saltiniroberto committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a9597c4 View commit details
    Browse the repository at this point in the history

  4. Fix mistake when restoring safe-block.md in previous commit

    @saltiniroberto
    saltiniroberto committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    528bbdc View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Merge commit fork-choice-changes-for-confirmaton-rule into confirmati… 

    …on_rule
    @saltiniroberto
    saltiniroberto committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    4926681 View commit details
    Browse the repository at this point in the history

  2. Fix error from previous merge

    @saltiniroberto
    saltiniroberto committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e735a58 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Fix comments 

    Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
    @saltiniroberto @mkalinin
    saltiniroberto and mkalinin committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    8c23187 View commit details
    Browse the repository at this point in the history

  2. Fix var name in get_committee_weight_between_slots

    @saltiniroberto
    saltiniroberto committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    6692612 View commit details
    Browse the repository at this point in the history

  3. Rename low lever get_confirmation* functions to compute_confirmation*

    @saltiniroberto
    saltiniroberto committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    cd0ad10 View commit details
    Browse the repository at this point in the history

  4. Use cell_div rather than the explicit formula 

    Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
    @saltiniroberto @mkalinin
    saltiniroberto and mkalinin committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    e365bc4 View commit details
    Browse the repository at this point in the history

  5. Rename committee_spans_full_epoch and committee_for_block_spans_full_… 

    …epoch
    @saltiniroberto
    saltiniroberto committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    d25b7ef View commit details
    Browse the repository at this point in the history

  6. Change implementation of ceil_div

    @saltiniroberto
    saltiniroberto committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    9fa4fca View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Apply suggestions from @mkalinin's review 

    Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
    @saltiniroberto @mkalinin
    saltiniroberto and mkalinin committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    992dea0 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Add handling of block from epoch prior to previous in is_confirmed

    @saltiniroberto
    saltiniroberto committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    508327e View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Calculate confirmation score for blocks prior to previous epoch as well

    @saltiniroberto
    saltiniroberto committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d6c25e1 View commit details
    Browse the repository at this point in the history

  2. Make the linter happy

    @saltiniroberto
    saltiniroberto committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e927509 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Remove get_safe_beacon_block_root and get_safe_execution_payload_hash… 

    … from new confirmation rule
    @saltiniroberto
    saltiniroberto committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    32232f6 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
    @saltiniroberto @hwwhww
    saltiniroberto and hwwhww committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    3787e96 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Stop recursion earlier in compute_lmd_confirmation_score

    @saltiniroberto
    saltiniroberto committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    8ff01f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Refactor test to improve code reuse

    @saltiniroberto
    saltiniroberto committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    cacdc04 View commit details
    Browse the repository at this point in the history

  2. Merge commit dev branch into confirmation_rule

    @saltiniroberto
    saltiniroberto committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    eebbe94 View commit details
    Browse the repository at this point in the history

  3. Fix issue in previous merge

    @saltiniroberto
    saltiniroberto committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    21b9d2e View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge 'dev' into confirmation_rule

    @saltiniroberto
    saltiniroberto committed May 2, 2024
    Configuration menu
    Copy the full SHA
    dff96e3 View commit details
    Browse the repository at this point in the history

  2. Update to match latest paper

    @saltiniroberto
    saltiniroberto committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c9caf62 View commit details
    Browse the repository at this point in the history

  3. Fix lint issues

    @saltiniroberto
    saltiniroberto committed May 2, 2024
    Configuration menu
    Copy the full SHA
    740be9a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Improve doc

    @saltiniroberto
    saltiniroberto committed May 3, 2024
    Configuration menu
    Copy the full SHA
    688aa19 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @saltiniroberto
    saltiniroberto committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4ad1cc2 View commit details
    Browse the repository at this point in the history

  3. Renaming

    @saltiniroberto
    saltiniroberto committed May 3, 2024
    Configuration menu
    Copy the full SHA
    be3648d View commit details
    Browse the repository at this point in the history

  4. Fix lint issues

    @saltiniroberto
    saltiniroberto committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b89e93b View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'dev' into pr3339

    @hwwhww
    hwwhww committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    696e22d View commit details
    Browse the repository at this point in the history

  2. resolve conflict

    @hwwhww
    hwwhww committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ff3daaa View commit details
    Browse the repository at this point in the history

  3. Fix argument sequence error

    @hwwhww
    hwwhww committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e0dc09b View commit details
    Browse the repository at this point in the history

  4. Move confirmation rule specs to Bellatrix

    @hwwhww
    hwwhww committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e6d9150 View commit details
    Browse the repository at this point in the history

  5. Clean up phase0

    @hwwhww
    hwwhww committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    687fd5c View commit details
    Browse the repository at this point in the history