Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a new config MAX_EXTENDED_MATRIX_SIZE #3708

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

kevaundray
Copy link
Contributor

This is pulled out from #3697

See rationale here: #3697 (comment)

Essentially we cannot have a SSZ list where the size is defined a A * B where A and B are constants

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested. Otherwise looks good!

specs/_features/eip7594/das-core.md Outdated Show resolved Hide resolved
@hwwhww hwwhww added the EIP-7594 PeerDAS label Apr 22, 2024
@kevaundray kevaundray requested a review from asn-d6 April 22, 2024 12:03
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks both!

@asn-d6 asn-d6 merged commit 858f516 into ethereum:dev Apr 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants