Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated phase 1: branch and early subkey reveal challenges #587

Merged
merged 28 commits into from
Feb 19, 2019
Merged

Updated phase 1: branch and early subkey reveal challenges #587

merged 28 commits into from
Feb 19, 2019

Conversation

vbuterin
Copy link
Contributor

@vbuterin vbuterin commented Feb 8, 2019 •
edited
Loading

Includes:

  • Branch challenges (ask for a branch of some signed attestation)
  • Responses to branch challenges
  • Code for calculating the subkey for some custody period (~9 days)
  • Mechanism for revealing subkeys, both punitively (if the subkey is revealed early) and legitimately (if the subkey is revealed after it's expired), with a proof-of-knowledge-based mechanism for preventing proposer stealing of early subkey whistleblower rewards
  • Cannot leave the withdraw queue until all branch challenges answered and all subkeys revealed
  • After a validator leaves the withdraw queue, they still cannot withdraw for ~1 day; this period can be used as an opportunity to initiate an interactive proof of custody challenge game (not yet included)

So far all of the machinery is agnostic to what is discussed in #568; everything after this point, however, will not be.

Not included:

  • The actual proof of custody game

@vbuterin vbuterin changed the title Updated phase 1: branch challenges Updated phase 1: branch and early subkey reveal challenges Feb 8, 2019
@djrtwo djrtwo added the phase1 label Feb 8, 2019
vbuterin and others added 3 commits February 8, 2019 19:40
@vbuterin
Revealing during the active period is still revealing early
10a3e1b
@vbuterin
Added....
c7891c8 
* Machinery for publishing old subkeys
* Inability to withdraw until you published all subkeys
* After a validator exits the queue there's still a minimum 1-day delay before they can withdraw (in the future this delay will be used as an opportunity to start a PoC challenge game)
@djrtwo
Merge branch 'dev' into vbuterin-patch-12
1e1e3ad
vbuterin added a commit that referenced this pull request Feb 17, 2019
@vbuterin
First draft of the PoC interactive game
1a2c255 
~~Likely~~ certainly has many bugs and is missing important pieces; intended more as a sketch, to be cleaned up once #587 is merged.
@vbuterin vbuterin mentioned this pull request Feb 17, 2019
Closed
@JustinDrake JustinDrake self-requested a review February 19, 2019 10:53
@vbuterin vbuterin merged commit 2540f55 into dev Feb 19, 2019
vbuterin added a commit that referenced this pull request Feb 19, 2019
@vbuterin
Properly do #645 on top of #587
62be7f5
@djrtwo djrtwo deleted the vbuterin-patch-12 branch February 20, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo left review comments

@JustinDrake JustinDrake JustinDrake approved these changes

Assignees
No one assigned
Labels
phase1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbuterin @JustinDrake @djrtwo @hwwhww