Do not duplicate bytes length when tree-hashing
#596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tree-hashing a `bytes` the length currently appears twice: 1) in the first four bytes of the serialisation 2) in the final `hash(chunkz[0] + datalen)` This is suboptimal: 1) It is unnecessary and causes an awkward 4-byte misalignment. 2) It is inconsistent with the way lists are handled. (`bytes` is just a list of `uint8`.) 3) Removing the 4 leading bytes is an optimisation opportunity when the Merkle root of the `bytes` object is already known.
|
I'd support making |
|
Yay, 47 lines removed! |
This was referenced Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tree-hashing a
bytesthe length currently appears twice:hash(chunkz[0] + datalen)This is suboptimal:
bytesis just a list ofuint8.)bytesobject is already known.