make getting assignments more generic #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| When querying for assignments in the next epoch there are two options -- with and without a `registry_change` -- which is the optional fourth parameter of the `get_committee_assignment`. | ||
|
|
||
| `get_committee_assignment` should be called at the start of each epoch to get the assignment for the next epoch (`current_epoch + 1`). A validator should always plan for assignments from both values of `registry_change` unless the validator can concretely eliminate one of the options. Planning for future assignments involves noting at which future slot one might have to attest and propose and also which shard one should begin syncing (in phase 1+). |
There was a problem hiding this comment.
I wonder if we need to mention if it's a genesis slot, get the assignment via (current_epoch)
There was a problem hiding this comment.
I'll actually make a separate "chain start" section in another PR
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
hwwhww
approved these changes
Feb 22, 2019
hwwhww
added a commit
to ethereum/trinity
that referenced
this pull request
Feb 26, 2019
…eneric (#301) * Address ethereum/eth2.0-spesc#673 * sync docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #668 by removing
get_next_epoch_committee_assignmentwith the more genericget_committee_assignmentthat can get validator assignments for prev, current, and next epoch.