Merkleisation friendly pending attestations #697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleaner presentation and conceptually
45 tasks
vbuterin
reviewed
Feb 27, 2019
vbuterin
reviewed
Feb 27, 2019
| @@ -1789,7 +1793,7 @@ The steps below happen when `(state.slot + 1) % SLOTS_PER_EPOCH == 0`. | |||
|
|
|||
| * Let `previous_total_balance = get_total_balance(state, get_active_validator_indices(state.validator_registry, previous_epoch))`. | |||
| * Validators that made an attestation during the previous epoch, targeting the previous justified slot: | |||
| * Let `previous_epoch_attestations = [a for a in state.latest_attestations if previous_epoch == slot_to_epoch(a.data.slot)]`. (Note: Each of these attestations votes for the previous justified epoch/block root because of the [attestation block validity rules](#attestations-1).) | |||
| * Let `previous_epoch_attestations = state.previous_epoch_attestations`. | |||
There was a problem hiding this comment.
Maybe just get rid of this line and use state.previous_epoch_attestations everywhere? A 6 character reduction is not normally worth a helper variable.
There was a problem hiding this comment.
I left it as is because of the nice helper variable symmetry:
- Let
previous_epoch_attestations... - Let
previous_epoch_attester_indices... - Let
previous_epoch_attesting_balance... - Let
previous_epoch_boundary_attestations... - Let
previous_epoch_boundary_attester_indices... - Let
previous_epoch_boundary_attesting_balance... - Let
previous_epoch_head_attestations... - Let
previous_epoch_head_attester_indices... - Let
previous_epoch_head_attesting_balance...
vbuterin
reviewed
Feb 27, 2019
| @@ -1779,7 +1783,7 @@ The steps below happen when `(state.slot + 1) % SLOTS_PER_EPOCH == 0`. | |||
| [Validators](#dfn-Validator) attesting during the current epoch: | |||
|
|
|||
| * Let `current_total_balance = get_total_balance(state, get_active_validator_indices(state.validator_registry, current_epoch))`. | |||
| * Let `current_epoch_attestations = [a for a in state.latest_attestations if current_epoch == slot_to_epoch(a.data.slot)]`. (Note: Each of these attestations votes for the current justified epoch/block root because of the [attestation block validity rules](#attestations-1).) | |||
| * Let `current_epoch_attestations = state.current_epoch_attestations`. | |||
There was a problem hiding this comment.
Same as with prev attestations below.
vbuterin
reviewed
Feb 27, 2019
djrtwo
reviewed
Mar 1, 2019
|
Assimilated into #711 |
This was referenced Mar 8, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleaner presentation and conceptually